theja-m / data-structures-and-algorithms Goto Github PK

Hello @theja-m first of all good work. Came to this repo from ZTM Data Structures. I found an issue in the array implementation.py code. I feel the code is just reinventing the wheel...i.e you are simply defining the lists(which are in-built in python) again. As per my understanding the main difference between a list & array is the latter takes homogeneous elements. This main part itself is missing is this code. Thanks :)

Hi theja-m,

The fibonacci code is pointing to wrong index.

fibanacci(5) should be 5 but it is giving 8
fibanacci(6) should be 8 but it is giving 13
fibanacci(7) should be 13 but it is giving 21

It is giving one index ahead.

Hi Theja-m,

I was referring this repo for DS in python. I found one issue with merge-sorted array algorithm that has been implemented.

for the input mergesortedarr([38, 27, 43],[3, 9, 82, 10]) the output comes as [3, 9, 38, 27, 43, 82, 10], which is not correct.

Can you please check and review?