thebb / costa Goto Github PK

In the API, how is the problem definition communicated? I am thinking of specification of the governing equation, domain geometry, possibly grid specification, and parameter definition. On a conceptual level, this can either be decided up front (and passed to the init of solver), or passed as a Parameter to the several methods. The former option will imply that the API in a certain sense is incomplete, while under the latter, reuse of discretization under subsequent calls will require checks that the problem parameters have not changed.

Related, have you decided on a format on specifying the problem, or is the plan to build a protocol for this as we move along?

A lisence should be set before the package is mentioned in publications.

``In the IOT physical model, the physics based model is assumed to have a function anasol

This is however not specified in API for PhysicsModels

I tried to find the implied method signature from the IFEM repository, but got lost in the class structure in that repo. Is it correct that the method implements something like

def anasol(params: Dict[str, Union[float, List[float]]]) -> Dict[str, np.ndarray]):
    return {'primary': np.ndarray([values_given_information_from_params])

@TheBB The method dirichlet_dofs() in the API is presumably aimed at finite element discretizations. For a cell centered finite volume discretization, where boundary conditions are discretized differently (in a certain sense) from interior dofs, it is not meaningful to ask for Dirichlet dofs. In such cases, should the method simply return an empty list?

Traceback (most recent call last):
  File "test/ifem-heateqn/test.py", line 4, in <module>
    from Costa.runner import Timestepper
  File "/home/kjetijo/Projects/CoSTA/Costa/runner.py", line 1, in <module>
    from functools import cached_property
ImportError: cannot import name 'cached_property' from 'functools' (/usr/lib/python3.7/functools.py)

From another issue it is pointed out that this is unsupported on python 3.7.

Commenting out the import and single line where it is used does make it run on older python versions.