thamara / time-to-leave Goto Github PK

Many electron-based apps download updates automatically and ask the user to restart to apply. I feel this is of best interest to this app, specially because people typically would download this application and use as is until they find a major problem with it, and then they'd have to come to GH releases.

It would be great if this was actually part of the next release.

Currently you can go on preferences and select which days to be considered "working days". I'd say it would be nice to have a compact view where the "non-working" days would be hidden.

Some people prefer one format over another, so it would be good to allow them to choose it.

Remember to remove the field "AM/PM" when in the 24h format

It should be possible to configure, on the settings, to minimize to tray, as this is an app that will be open, at most, 4 times a day.

I don't know why, but when I opened it for the first time, the whole screen was blank and it only appeared after I cleared the database once.

If you take a close look, the clock icon is misaligned at the header, being a bit to the right of the table and it is kind of weird.

Preferences page should have:

• Show Saturday/Sunday
• Hours per day
• Enable/Disable notification

More...

Changing/adding/removing fields in the preferences file make the old preferences file not backwards compatible, as hasValidPreferencesFile checks that all the expected preferences are presented in the file.
We should be able to overlook missing fields, fallbacking to the default specified value, and inserting this missing value into the preferences file.

There should be a summary view, or similar, so that you can see how many hours you have extra or to be paid.

We all know we don't/can't work exactly h a day hahahaha

When using the release (not compiling it locally), the icon doesn't work

If you arrive at 08:00AM, then lunch can't be earlier than that. Same applies for all other registries.

The balance on the app is currently:

If the number is negative (means the user is missing working hours) it should be red. If the balance is positive is should be green-ish.

Seems kind of obvious, but I guess it would be nice to list Node.js as a dependency, so illiterate people can know how to start getting npm

Given that npm run test was broken, as mentioned on #17, it might be worth setting up a GH Action CI that runs on a windows machine

I typed 8:13AM as day end, but then erased it. Day total still kept the old sum

If the current day is a non-working day, I think the punch-in button should be disabled. Currently it is possible to click it, but nothing happens.

You can also make it pop-up an error/warning, which I dislike a lot more.

I did not check other months.

Issue #55 introduced the ability to punch from tray, but it is always enabled. It should follow the behavior of the button on the main window, which is disabled if the day is a non-working day or if all entries have already been punched.

When trying to test it for #21, I couldn't see anything, just like #6 . I even ran npm install first.
I got the following error:

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at hasValidPreferencesFile (C:\Users\Tulio\Documents\GitHub\time-to-leave\js\UserPreferences.js:56)
    at getUserPreferences (C:\Users\Tulio\Documents\GitHub\time-to-leave\js\UserPreferences.js:99)
    at calendar.js:16

There should be a "punch in" button somewhere, so that it can record the current time as the next entry in whatever field is next on the current day, easing the job of typing everything.

Currently the option to hide non-working days is centered and has a bold font:

I feel like this is somewhat clutter.
It should be left-aligned, and have a normal, non-bold, font. Also, have a little spacing from the options above it.

If you close the main window, the preferences one stays alive and yields the following exception when you try to close it:

When typing a time, whenever user hits 'tab', the current field should be auto-filled with 0s. I'd do it like:
'--' + tab -> '00'
'3' + tab -> '03'
'--' + tab -> AM/PM (always AM or PM if previous is already PM)

I did npm install then npm start and faced #6 again (actually took multiple reload + clear database to "work"). This is what I got then:

Note that:

• Icon is broken (~ #18)
• Rows are not editable (I'm guessing a bug on reading the preferences)
• Editing the preferences brings edit back, but then punch-in buttons do not fill, but actually clear the field:

It should be possible to punch in time from the icon on the tray, by right clicking it and selection an option 'Punch in time'. This way the user don't even need to open the app.

Add database from csv file.

I believe the application would look nicer if the scroll is in the time table instead of the whole app.
Then you can always see the title and headers.
It would look similar to what was done to the punch time button and statistics.

User can left TTL opened for days in their computer, but we don't update the page (to show the current day correctly).
We should redraw/update the calendar when the day change.

I believe this can be achieved by using setInterval, and querying the today on the calendar.

It wasn't rocket science to figure out what it does, but I think a tooltip would be helpful

Tried running the npm run test command and got the following:

Log as attached
2019-09-17T03_47_49_320Z-debug.log

App should open on a size that already fits the whole month, if the screen has enough resolution for such,

If you've punched the four times required in a day, the button should either:

• Be disabled
• Replace the last punched-in entry (with optional confirmation dialog)

Though the notification shows up pretty on mac, as shown by the screenshots on the README, they have a random icon on Windows:

Current app is black on white, but maybe some people prefer the other way around?
I do!

In the future you could also allow it to be fully customisable.

Currently the toolbar icon is black, which looks great on light toolbars, but bad on dark ones.

It should be grey/ice for Windows and keep black for mac, maybe

The notification is one time currently. It would be nice if it shows every 5 (?) Minutes, until user acknowledges it.

It would be great if the users could type in their locations and the calendar would adapt accordingly including holidays.
There are several ways to make this more complex

• Start with just a country
• Move to city-based
• Make app read approximate location, instead of having user type it

When you open a "menu" the dialog contains the bar with "Menu", "Edit" and "View".

That doesn't seem to be necessary.

Fix paths

After #45, the notification appears to the user until the end of the day, every 5 min.
I think the user should be able to control this interval, and maybe the maximum number of times the notification appears.

We should add this under preferences page, which currently have:

There should:

• check box for disabling repetition of the notification (not checked by default)
• input (number) in minutes for the Interval of notifications
• input (number) for the max number of notification to shown

It's important noticing that such configuration should be saved in the preferences, and should be sourced in calendar.js/notifyTimeToLeave.

It should be possible to waiver a working day.
An idea is to right click the day on the table and have an option waiver, which would open a pop up for the user to input the reason and optionally how many hours to waive.

I feel like the bar telling you when to leave should change in some way when you've punched in all entries for the day. I don't know what to do though, if it should be hidden, or just rewritten...

Currently the app just annotates the time when you punch, but it can actually know whether you are punch in or out, depending on whether it's an even or odd punch.

It would be great if it had inner logic saving whether you're working or not and if you punched out and the computer became idle, suggesting you to punch in upon coming back.

After #39, the menu on Macs is not showing up.
According to browser window documentation, setMenu only works in Windows and Linux.

New users often will not start using right in the start of the month. So, it would be nice to be able to set the date from which hour count starts.
Perhaps, if this date is not set yet, then the 'time-to-leave' can auto configure it for the first time I open the program.

Time to leave should not be higher than 23:59

Add tests for time math

Currently, on calendar.js we handle the update of the preferences (ipcRenderer.on('PREFERENCE_SAVED'), as well as the queries of the preferences in functions such as notificationIsEnabled, getHoursPerDay and showWeekDay.
All of this should be moved to js/UserPreferences.js, and imported in calendar.js, just the way it's done for getUserPreferences.

Add help menu. On this we should have:

• TTL on Github (with a link to this repository)
• Latest releases (pointing to https://github.com/thamara/time-to-leave/releases)