textmate / make.tmbundle Goto Github PK

From @ds0nt on June 13, 2017 22:51

• VSCode Version: 1.13.0
• OS Version: Linux

When editing a makefile, sometimes things don't color as prettily as they could.

I've noticed this when using an ifeq block, in particular.

As you can see, the variables that are indented are not colored, and neither is the else ifeq.

Copied from original issue: microsoft/vscode#28668

From @Leedehai on June 19, 2017 20:22

• VSCode Version: 1.13.1
• OS Version: macOS 10.12.5

Steps to Reproduce:
In this Makefile snippet, the variable "HCC_LIB_OBJ" in the second line is not properly colored, due to comment at the end of the first line. If the comment is removed, "HCC_LIB_OBJ" is colored correctly. But "HCC_LIB_OBJ"'s colorization should not be affected by whether there is a comment in the preceding line.

Copied from original issue: microsoft/vscode#29048

Is there a way to hide the color code escape sequences? I'm using the latest TextMate 2 update v2.0-alpha.9513.

Example:

Maybe this should be an issue on TextMate rather than the bundle, but I figured I would start here.

From @Leedehai on June 21, 2017 0:4

• VSCode Version: 1.13.1
• OS Version: macOS 10.12.5

Steps to Reproduce:
In this Makefile snippet's dependency list, if the variable $(T_AUX_MESSAGES_DRIVER_SRC) is put before the function call $(addprefix $(T_PROJ_SRC_DIR), $(...) $(...)), then "addprefix" is not properly colorized.

If I change the order, "addprefix" colorization is fine.

This bug might be present with other functions as well, like "patsubst", but I didn't try..

Copied from original issue: microsoft/vscode#29148

The bundle wants to change directory to the project directory, but it could just fallback on TM_DIRECTORY, or actually, the dir part of TM_MAKE_FILE (preferred over TM_DIRECTORY, when TM_MAKE_FILE is set).

GitHub uses this bundle for Makefile syntax highlighting. Please have a look at this gist:

https://gist.github.com/philtay/5a647f5a573d1052e7f7

The same problem affects TextMate.

Repro:

define foobar
$(and $(filter-out undefined,$(origin 1)),$(1))
endef

define test
command
endef

Ref: github-linguist/linguist#2710

If a string contains an escaped backtick, the grammar still treats the backtick as the the start of shell-interpolation.

This commit tweaks that, so the syntax highlighting isn't broken from that point on: http://github.com/adamv/make.tmbundle/commit/6071f98f9f60b421602579bead75faaabc5bb24e

I tried using this tm bundle within PhpStorm, (I've successfully used others in the past), however it doesn't seem to work for *.mk files.

From my limited knowledge of tmbundles, this is because the file extension is missing here.

That said, I tried changing the file locally and it still wouldn't work... I'm sure I'm missing something - I don't know much about how tmbundles work..

Hi,

with the Makefile below, the "build target..." command doesn't work for me. What happens is a brief flash of a white window that disappears immediately, with now effect.
Here is the makefile:

target1 :
c++ blabla.cpp blabla.cpp -o /tmp/blabla

target2 :
c++ blabla.cpp blabla.cpp -o /tmp/blabla

From @akshaya-a on April 26, 2017 20:29

The following lines in CNTK's Makefile appear to break syntax highlighting in VSCode. The first breaks all highlighting after it, and the nested ifdefs don't show up highlighted as "ifdef". I don't know enough about any of this to say whether this is a VSCode or CNTK problem, but thought I'd start here :)

Apologies for weird markdown due to code

1. Line 103

CXXVER_GE480:= $(shell expr `$(CXX) -dumpversion | sed -e 's/\.\([0-9][0-9]\)/\1/g' -e 's/\.\([0-9]\)/0\1/g' -e 's/^[0-9]\{3,4\}$$/&00/'` \>= 40800)

2. Line 122

ifdef CUDA_PATH
  ifndef GDK_INCLUDE_PATH

• VSCode Version:
  Version 1.11.2
  Commit 6eaebe3b9c70406d67c97779468c324a7a95db0e
  Date 2017-04-13T08:03:11.395Z
  Shell 1.4.6
  Renderer 53.0.2785.143
  Node 6.5.0
• OS Version:
  Windows 10 Creator's Update

Steps to Reproduce:

1. Open https://github.com/Microsoft/CNTK/blob/master/Makefile

Copied from original issue: microsoft/vscode#25469

As a result, running a makefile that works in Terminal.app from TextMate.app can fail or produce unexpected results.

in this example, "build" in line 1 should not have the same color as "style.css" because it's a phony target

build:
    npm run build

style.css: style.scss
    sass style.scss

.PHONY: build

This should help to check if a target is not in .PHONY