"explicit parent script" not working about scripty HOT 14 CLOSED

Thanks for this load test.

from scripty.

Just to clarify:

1. "test:browser": "scripty" is in your package.json, confirm?
2. When you run npm run test:browser, both scripts/test/browser/dev.sh and scripts/test/browser/index.sh are being run, right?

What if you rename index.sh to index? If that fixes it then the lib/resolve-script/generate-glob module is probably to blame

from scripty.

As always I'd appreciate any help you can offer, whether it's a way to reproduce the issue, a test, or a PR. Thanks

from scripty.

"test:browser": "scripty" is in your package.json, confirm?

yes

When you run npm run test:browser, both scripts/test/browser/dev.sh and scripts/test/browser/index.sh are being run, right?

yes

What if you rename index.sh to index? If that fixes it then the lib/resolve-script/generate-glob module is probably to blame

This fixes the issue.

from scripty.

in generate-glob you could probably leverage the glob module to avoid both fs.statSync() calls, and fix this.

from scripty.

...but that may not be any faster. sounds silly to generate a globspec using glob

from scripty.

also: ensure index is not a directory 😄

looks like you have that covered

from scripty.

this line should probably be

return path.join(expanded, '*')

the following

return path.join(expanded, '/') + '*'

is not windows-safe, afaik. the purpose of join of course is to insert the proper directory separators for you

from scripty.

return fs.statSync(f + '/index').isFile()

isn't windows-safe either, right? probably want

return fs.statSync(path.join(f, 'index')).isFile()

but you may blow that away if you change your strategy anyway

from scripty.

I think you can do the index check before you do the dir check too.

this might do it:

// untested
module.exports = function (dir1, dir2) {
  var expanded = path.resolve(dir1, path.join.apply(this, dir2.split(':')))
  // find any index files beneath expanded.  if it's not a directory,
  // this will fail
  var indexGlob = path.join(expanded, 'index*')
  if (glob.sync(indexGlob, {nodir: true}).length) {
    return indexGlob
  }
  // check if expanded is actually a directory
  var dirGlob = path.join(expanded, path.sep)
  if (glob.sync(dirGlob).length) {
    return dirGlob + '*'
  }
  // otherwise, default
  return expanded + '*'
}

from scripty.

A couple questions:

1. Are you on Windows?
2. Are you able to reproduce with a test? I tried last night and failed

from scripty.

Nevermind, was able to reproduce

from scripty.

I'm not on Windows.

from scripty.

Thanks for your help with this. Fix landed in 1.2.3

from scripty.