Options won't work with npm >= 7 about scripty HOT 7 CLOSED

cc/ @jasonkarns for visibility and/or 🧂

from scripty.

@searls too late. I was railing about this on Twitter when this behavior was announced (while npm7 was still in beta)

https://twitter.com/JessTelford/status/1258549958728286208
https://twitter.com/jasonkarns/status/1293736534403887106

npm/rfcs#183

from scripty.

I'm not likely to have time to work on this soon, but I want to note what I've found about fixing this so far.

Here's what I think options compatibility with npm 7 will require:

• Figure out how to handle implementing and testing this in both npm 6 and 7; npm 6 is still the default for LTS versions of node (v10, v12, and v14 as of this writing), so I think it makes sense to support both versions
• Code that uses npm_package_scripty_* (just lib/load-option.js) will need to be updated to also/instead use npm_package_json (per the RFC) and then parse the file from that env var to find scripty options
• Update several test files (lib/load-option.test.js, test/safe/modules-test.js, test/safe/relative-path-loading.js) that specify npm_package_scripty_* env vars to also/instead work based on npm_package_json

from scripty.

So, are you going to to something about this ?

from scripty.

+1

from scripty.

Seems to be an even bigger issue with yarn 2+ as currently does not have npm_package_json available

yarnpkg/berry#2436

from scripty.

This should be resolved in scripty 2.1.0 (via #105). Note that you'll want to put your scripty config underneath a config key, per the updated README. Feel free to comment/reopen if this is not actually fixed!

from scripty.