teratech / mmm-wifipassword Goto Github PK

I have set the config showPassword: 'false', but the password is still shown under the QR code.

Describe the bug
Configure a center position. It will get ignored and Module will be aligned to left position. Additional the headline line will be across the whole screen.

To Reproduce
Steps to reproduce the behavior:

• Configure a center position.

Expected behavior
Module will be at this position

Desktop (please complete the following information):

• Raspberry 3B+ with installed Image of MagicMirror

When using a SSID name with localized characters the qr code won't show
Just replace the qrcode.min.js by the non minified version from https://github.com/davidshimjs/qrcodejs and it will work as intented

Hey,
can anybody help me. It works totally fine with an "normal" WIFI network but i cant connect with an WIFI-6 network.

Thanks

After updating the MMM from v2.10.1 to v2.17.1 the QR Code did not show up any further. After some tests, I found, that there is no notification "DOM_OBJECTS_CREATED" send to the referenced function - thus the QR code creation does not take place. Instead the notification is named "MODULE_DOM_CREATED". Adjusting the switch statement seems to fix this issue, but should be checked further. My fix is as follows:

...
switch(notification) {
  case "MODULE_DOM_CREATED":
...

Hello,
One feature that I would find interesting is the ability to display or not the QR code.
I tried so and it works fine:

In MMM-WiFiPassword.js:

• Add the variable: 'showQR: true'
• Modification of the following code:

if (this.config.showQR) {
	  var qrDiv = document.createElement("div");
	  qrDiv.id = "qrdiv";
	  qrDiv.className = "qr-image";
	  qrDiv.style = "width:" + this.config.qrSize + "px; background-color:" + this.config.colorLight;
	  if (this.config.layoutVertical) {
		qrDiv.className += " layout-vertical";
	  } else {
		qrDiv.className += " layout-horizontal";
	  }  
	  div.appendChild(qrDiv);
	  }

So we only keep the text, which is sometimes enough.

FR / EN translation by Google, sorry.

Hi, thank you for creating this module. I'd like to make the folowing feature requests:

• make display of text optional
• optionally display the text next to the qr code, not below it

Hello! I was wanting to ask about special character support, and potentially even help create the change. I just am not sure which characters specifically need to be fixed for QR codes. I believe the change would be to send the strings to functions that escape and return the escaped character versions in the lines here?

If you can provide a list of the characters or documentation to find the characters to concern ourselves with, then I can assist in adding this capability.

Hello @TeraTech,

while using your MMM-WiFiPassword I have noticed some scanning issue. Since Android 10 there is an option available to scan a QR-Code for accessing Network right underneath the Network section on for example a Smart Phone (attached Image). I tested scanning with this option on several Android devices, but it didn't worked for me. Using the scanner I can see the QR-Code created by your MMM-WiFiPassword but it wont show up any further reaction. Now I am using a third party app. Some worked just fine others not. Maybe there are some differences in the types of network QR-Codes.

Is there an opportunity you can change the MMM-WiFiPassword so we can use the integrated QR reader on Android? I would appreciate.

If I am right with the idea of different network QR Types maybe you can build a little switch so users can decide which Type do they need.

I don't know if this issue only happens to me, but I thought is still worth to share with you.

Tested on OnePlus 6 OxygenOS Version 10.3.5

Is it possible that this will get support for enterprise (PEAP) networks?
these require user login.
would help me out big time

thanks in advance

Hi,

Is there an issue with the QR code background? I have a white box around my QR as shown in the picture here.

I have tried removing and reinstalling the module and moving the position to different areas of the screen

All software is installed properly and the config.js is correct as well. Double/triple checked everything yet when I launch the MM nothing shows up. Any idea what could be wrong?

Within the terminal it says "Error! Could not find main module js file" for MMM-WifiPassword. I don't know why it doesn't seem to be able to locate it, because everything is there when I go into the file itself. Any ideas on how to fix this would be appreciated.

Describe the bug
I am using the showAuthType, showPassword, showNetwork: "false" flags, but they are showing regardless.

To Reproduce

		{
			module: 'MMM-WiFiPassword',
			position: "bottom_right",
			  config: {
				//See 'Configuration options' for more information.
				showAuthType: "false",
				showPassword: "false",
				showNetwork: "false",
				network: "**REMOVED**", 
				password: "**REMOVED**",
				header: "Scan for WiFi",
				qrSize: "250",
			  }
		  },

Expected behavior
Display Heading, QR Code and nothing else.

Desktop (please complete the following information):
Latest Raspbian
Chrome on Windows 10, but also local on the rPi - Chromium / Magic Mirror local display
Latest

Is this a bug or have i misconfigured something that you can see?

The plugin should support the shared header functionality of the module framework instead using it's own header.

{
  module: 'MMM-WiFiPassword',
  header: 'WIFI',
  position: "top_right",
  config: {
    header: '',
    ...

See https://docs.magicmirror.builders/development/core-module-file.html#subclassable-module-methods

Hello,
this day on my MM 3 update was displayed, MMM-GoogleAssistant, MMM-Assistant2Display and MMM-WiFiPassword, after performing the updates of MMM-GoogleAssistant, MMM-Assistant2Display, I was not asked to update update of MMM-WiFiPassword, is this normal? How else to update MMM-WiFiPassword?

Is your feature request related to a problem? Please describe.
I have more than one WiFi network, i.e. a 5GHz and a 2.4GHz band.

Describe the solution you'd like
Hence, I would love to be able to display both QR Codes at the same time, either stacked or next to each other.

Could this be implemented?

Describe the bug
In the github preview image there is no white line above the QR-Code
Integrating the module adds a white line which I want to remove.

To Reproduce
Steps to reproduce the behavior:

1. Install MMM-WifiPassword
2. Launch MM
3. See error

Expected behavior
There should not be a white line - as seen in the preview image.

Screenshots