terasology / fluid Goto Github PK

May belong more in JS or TTA, although it would be nice to have such utility here.

Can "top off" a portable herbalism station in TTA now and end up with a partially filled bucket. But then can't fill said bucket from a water source :-)

Probably that should be doable if you have a partially filled bucket or there should be an easy way to dump the contents of a bucket. Maybe we can standardize a click system for that. Left click dumps, right click fills? Or right click on anything other than a water source dumps/fills the target if appropriate?

The portable herbalism station has a slot in it for water while the sifting table can be filled by right clicking it while holding a full bucket.

Again pinging @Josharias and @xrtariq2594

See MovingBlocks/Terasology#1802 for details. Minor validation is now in place to catch the crash, but the asset parsing needs to be fixed and hardened more properly (or possibly the asset definition needs to be tweaked instead?)

Pinging @MarcinSc @flo @Josharias to see if one of you could get to it sometime - probably a fairly easy fix for one of you :-)

On testing #8 I noticed WoodAndStone uses liters in its WoodenBucket.prefab) while JoshariasSurvival uses milliliters (wow that word looks awful written out in full)

This results in Fluid listing wildly different amounts in the tooltip showing how much liquid is in a bucket. WaS gets "10000" (as it sets a bucket's capacity for 10 liters) while JS gets "1000000" (with a bucket set to 1 liter, but as 1000ml). Actual items work as expected (portable herbalism station in WaS or sifting table in JS)

We should pick one or the other, or even both but set more explicitly somehow. It may also be worth merging bucket implementations and making them hold the same amount of water. Can we put a generic/abstract bucket in Fluid then have WaS and JS delta prefab in their specific extras, like how to craft one? Or put a template in Fluid and have them extend it?

It may also be worth some thought how to display number separators (a , or . for each 000 segment) as that differs internationally. We could simply avoid it entirely until internationalization is ready (just list "10000") for modules and prefabs, at which point we could probably code in the right separator in the language definition and use it intelligently via translation.

Pinging @xrtariq2594 and @Josharias