terascope / workflows Goto Github PK

After Teraslice got converted to typescript 5.2, it caused an update to scripts that makes it incompatible with node 14. It may be time consider removing node 14 tests entirely from all assets. This would allow for the following updates:

• Updating scripts dependency
• Updating nodegyp dependency to latest version

We are dropping support for node 16, updating node 18 to 18.19.1 and adding node 20 at version 20.11.1.
New node matrix array: [18.19.1, 20.11.1]

Issue explaining why node 16 no longer works on asset tests: terascope/teraslice#3544

We will do this in two steps: (1) removing node 16 and updating 18, then (2) adding node 20

I want to add a simple teraslice asset that can be used to help develop the actions in this repo. It should generate the same outputs as the normal assets: zipped/bundled assets for each node version and a dummy npm package.

@jsnoble had added the yarn cache to some of his node setup actions as did I, but I thought they weren't working. I did just find some evidence of this working on the standard-assets project:

• Here it says the cache was found and used:
  • https://github.com/terascope/standard-assets/actions/runs/5193111840/jobs/9363254637
• Caches show up here:
  • https://github.com/terascope/standard-assets/actions/caches

Obviously this is a feature we want, but we want to make sure we understand it well enough to use it properly, we want it to work.

As can be seen in this workflow run:

https://github.com/terascope/standard-assets/actions/runs/5193111840/jobs/9363254637

The dependabot PR tests fail when it tries to login to Docker. I am pretty sure this is because secrets are not exposed to people outside the organization.

Thoughts:

• Maybe we can add a conditional for dependabot
• maybe we can cache docker images to make that login unnecessary since the images are public, we login to avoid the pull limit