tepi / listbuilder Goto Github PK

Hi,

I have tested Vaadin 7.3.0.beta1 and Listbuilder 0.7.3.v7BETA with the new Valo theme. Seems that up, down, remove, left and right button icons are rendered incorrectly in buttons. Seems to occur with Firefox 31 and Chromium 36 in Linux. Attached is a screencapture of the issue.

Here is the code for simple test app:

@Theme("valo")
public class ListbuilderdemoUI extends UI {
    @Override
    protected void init(VaadinRequest request) {
        final VerticalLayout layout = new VerticalLayout();
        ListBuilder listBuilder = new ListBuilder("Test");
        listBuilder.addItem("Item1");
        listBuilder.addItem("Item2");
        listBuilder.addItem("Item3");
        listBuilder.addItem("Item4");
        layout.addComponent(listBuilder);
        setContent(layout);
    }
}

In the vaadin directory the version 0.7.3.v7 ist still used, and the 0.7.4.v7 is not accessible via Maven

If it's possible, please make selectionsListBox and optionsListBox protected to allow extending VListBuilder.

I'm currently working on a project, and would like to utilize this amazing add-on and extend it, but I'm unable to do so because of the private modifiers of most elements.

Thanks for ListBuilder. It's truly a handy add-on.

Hi,

First of all: Thanks for having developed ListBuilder and thanks for supporting it.

Yesterday, I used ListBuilder for my app and it works very well.

Nevertheless, I found an issue related to the usage of Converters. If you assign a Converter to the component (using setConverter()), it will be used, but the List that is being returned by convertToPresentation() will never appear.

I found that AbstractSelect is using setInternalValue() in order to set the converted value. ListBuilder however relies on setValue() being called (which is not the case in the described situation).

So I had to override setInternalValue() to call setValue() to make it work. Such things however should be managed in the ListBuilder class, I think.

Thanks,
Markus

hello,
is there any way to create vaadin list builder column and button fixed width size.

Steps to reproduce:

1. add a ListBuilder and setRequired(true)
2. add some items, and then setValue(some of the items)
3. call isValid()

Although it should return true because a value != null was set, it returns false. I believe it's due to the method inherited from the superclass using it's internal object list instead of "orderedValue". As soon as 1 item is transferred, the internal state is updated and things work well.

Using 0.7.1.v7 with Vaadn 7.0.1

Cheers