temikfart / sql2cypher Goto Github PK

Add unit-testing for enums, validation, methods with return value and all cypher units like structures and clauses builders.

To easy tool installation we need to have packaging scripts.

• For Windows and Linux (.deb) and MacOS packages we can use CPack.

Add unit-testing for the utils methods in include/SCC/ast/common/utils.h and each AST node class.

Need to move arguments parsing to another place. Also, I want to see more clear code.

I suggest to store current MS SQL grammar, which is implemented in Parser, using CLion plugin Grammar-Kit.

Query Assembler should be refactored and decomposed as well as Parser (#36).

README.md is not actuale for now. There are no information about new argument parser, how configuration works and how to write tests.

Now, the configuration module is very bad, because there are a lot of methods for validation with dirty error messages, bad argument parsing implementation, etc.

Now, INode class plays a double role: INode and Lexem. Lexer must parse input file to lexem, Parser must take Array of Tokens/Lexems and create AST nodes. These tokens should have only one DataType and do not know about Statements.

• Rename to Parser, it is shorter and more convenience;
• Decompose methods;
• Review logic.

Add unit-testing for the enums, classifiers in Parser module. Also, we can test validation methods and methods with the return value.

Now, module, which is responsible for the logging in the application, is very bad coded. I suggest to use open-source logger. Also, we need to remove any logs from configuration module and break the connections between configuration and logging modules.

When some function, for example, PrintHelpAndExit(), prints help info in stdout inside the EXPECT_EXIT macro, this function output will be in the final output near the logs from Google Test framework. This invalid behavior, because test output makes it difficult to read test results.

If I run SCC with the following command:

scc --sql="/path/to/sql_queries.sql" --mode

where I didn't specified any parameter for the --mode, scc will use default value for the --mode, but I think it is incorrect. Need to raise an error in this case.

Now build.yml runs GitHub Actions only for ubuntu. Need to add build and test scripts for MacOS and Windows for cross-platform testing.

• Unnecessary getters and setters in ast.h;
• Outdated docs;
• Unnecessary unused methods;
• Class Node contains two entities inside: lexem and AST node. It should be separated to two pieces.

Now, Parser add to AST, for example, ;, which separates SQL queries between each other, but I think it is not necessary. We can link queries to the root without these separators.

Situation now:

To fix C++ Code Style in the project need to use, for example, Clang Format in CI and check it for each merge request.

We can generate enums and its string representations using scripts like this in ChaiVM.

Now, all build logic placed in the only one CMakeLists.txt in the root of project. Need to use CMakeLists.txt for each directory with sources and tests using add_subdirectory.