Giter Club home page Giter Club logo

app-telos-native's People

Contributors

boid-com avatar dependabot[bot] avatar devartemnuss avatar donnyquixotic avatar karynemayer avatar kersten-cr avatar kylan-ridian avatar kylanhurt avatar pmjanus avatar poplexity avatar tusharkarkera22 avatar viterbo avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

app-telos-native's Issues

Adjust decimals for casted vote % and number of tokens voted

Frontend of ballot/vote/ammendment page is "messed up" based on decimals displayed for NO votes. Abstain voted format to be verified, too.

Voted tokens to be displayed as integer (no decimals) as not relevant information for the process.

To Reproduce

  1. Open Decide page
  2. Select an active proposal
  3. Verify user interface for cast votes

Expected behavior
Percentage of yes/no/abstain votes should be limited to 2 decimals to assure a readable display.

Amount of tokens voted should have no decimals.

Screenshots

Bildschirmfoto 2022-09-15 um 15 47 07

Desktop (please complete the following information):

  • OS: MACOS Monterey
  • Browser: Chrome
  • Version: 105.0.5195.102 (Offizieller Build) (x86_64)

Can't properly filter ballots by type

Describe the bug
By default, the filters have active and VOTE selected. If you change the type to proposal, it will only show the proposals from that list, but the same doesn't happen with poll. When selecting the poll type, the list is empty even though there is one item at the list.

To Reproduce
Steps to reproduce the behavior:

  1. Go to ballots
  2. See that the listed ballots (with active and VOTE) contain one poll (/ballots/rbqs4bmmel2w/1663123846224)
  3. Scroll up
  4. Add the type filtering with poll selected
  5. There are no ballots returned

Expected behavior
The ballot of type poll that is active and belongs to the VOTE treasury should appear.

Can't see any ballots on testnet

On click of 'decide together' ballots never load. There seems to be an infinite loop where 'next_key' is never updated when fetching ballots from the table. Could be bad data on testnet.

Image

Tokens page broken

Describe the bug
tokens page not displaying

Additional context
displays on current app main

update component file names

There are many vue components using non-vue file name conventions

  • change any vue component files (*.vue) to 2 or more words using pascal case e.g. gavatar.vue is now ProfileAvatar.vue
  • name should reflect file name in kebab case e.g. profile-avatar
  • remove any vue ignore rule comments allowing single word component
  • update any imports and implementation(s) e.g. import ProfileAvatar from 'src/components/ProfileAvatar.vue, profile-avatar( :props )

Infinite scroll requires scroll to show first results

Describe the bug
When reaching the ballots page, you can see the three dots indicating a request is being made, and it stops after a few seconds. If you don't scroll down on the page, the ballots don't show.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the ballots page
  2. Don't click on anything or scroll
  3. See the three dots being animated
  4. See the three dots disappearing
  5. No ballot is shown

Expected behavior
Active ballots from the VOTE treasury should be listed

Screenshots
Screen Shot 2022-09-13 at 20 09 06

Develop the ballot creation re-design

Is your feature request related to a problem? Please describe.
To enable users to create their proposals smother, we want to design a form that leads them on the right path to it. Right now, we're not completely sure what a proposal should have as information and what is acceptable or not beyond what the smart contract allows.

Describe the solution you'd like
Implementation following what has been accepted by #146

  • Unit tests should be added to all related components

Update the menu to reflect current functionalities

Is your feature request related to a problem? Please describe.
Right now, we have several links in the top menu that are not needed or lead to broken features.
In order to make the voting process smother - which is the current main value app telos delivers - we would like to remove them. That way, we eliminate non-working stuff from the vision of the user and allow them to focus on their task.

Describe the solution you'd like

  • Remove Contacts link from top menu
  • Remove Tokens link from top menu
  • Remove sub groups from Decide
  • Rename Decide to Proposals
  • Rename Groups to DAOs

login discarded on refresh

Describe the bug
refreshing after log in logs out

To Reproduce
Steps to reproduce the behavior:

  1. login via Anchor
  2. refresh page
  3. see logged out status

Expected behavior
should auto login from cache/authenticator on refresh

Hide/disable buttons that require user to be logged in

When a user is not yet logged in, or they are not registered on the treasury that the ballot is for, the buttons should be more accurate. Right now when you are not logged in the button says "View proposal & vote" but you cannot vote. And if you open that ballot when not logged in, it lets you pick options and shows the vote button.

Bug: Unable to add Ballot Options

Description
When you add options, there are no clear instructions of how to do it.
On Create the Option map is cleared.

Reproduce
Create a new Ballot of type Proposal
Add Options: a,b,c
Before Signing the map is cleared

cleared_after_input

no_data

Opening ballots

Describe the bug
When opening a ballot, the app crashes

To Reproduce
Steps to reproduce the behavior:

  1. Go to the ballots list
  2. Remove the active filter
  3. Select one proposal
  4. See VueJS internals error and parsing error
  5. Requires page reload

Expected behavior
User can continue using the site, including closing the opened proposal details

Screenshots
Screen Shot 2022-09-18 at 23 37 53

Browser: Chrome 105.0.5195.125 (Official Build) (x86_64)

Additional context
Note that the closing icon goes away and the page ceases to be functional.

Remove main page

Is your feature request related to a problem? Please describe.
To make voting even smoother, we would like to remove the main page and display the proposals. This will remove an extra click the user needs to get to the proposals.

Describe the solution you'd like

  • Remove the main page entirely
    Screen Shot 2022-09-15 at 09 50 22

  • Redirect the user to the proposals page

Remove filtering by type

Is your feature request related to a problem? Please describe.
Because we're separating the elections in another tab, we will want to remove election from the type filter.
The leaderboard type is also a type that we don't think is being used as well.

Describe the solution you'd like

  • Remove election from the filter type
  • Identify if leaderboard is being used and when. If it makes sense, remove it.

Describe alternatives you've considered
We should be aware that all the filtering must work as expected, so the remaining types must be tested.

Default Gravatar plugin not implemented

Describe the bug
default placholder gravatar pfps not displaying

To Reproduce
Steps to reproduce the behavior:

  1. navigate to contacts page
  2. see list without default gravatar profile images

Expected behavior
should display placeholder gravatar pixel images (see current implementation)
Screenshots

Additional context
gravatar is implemented via Vue.use() need to implement via app.use() in new implementation

Test for ballot creation failure modes and fix

There are likely many ways that creating a ballot can fail, we should prevent all of those cases in the ballot form, do not let the user click create unless we have checked everything to be sure the ballot is valid.

bug: token creation form triggers form validation too early and also displays a wrong error about terms acceptance.

Describe the bug
When creating a new token, after accepting the terms, the form already shows some errors before the user even makes a move.

To Reproduce
Steps to reproduce the behavior:

  1. Go to tokens page
  2. Click on create new token
  3. Accept the terms
  4. 'Decimals' required field is already showing an error
  5. click on any place on the screen (not over a button)
  6. A wrong error displays "You must accept the terms"

Expected behavior
Never show the error in step six (the user can't proceed if terms are not accepted). The Decimal field requirement error must be shown only after some interaction with the user.

Screenshots
form-error-too-early

Cancel button triggers form validation

Describe the bug
When trying to cancel a new ballot form, all the checks are activated and the user is forced to reload the page

To Reproduce
Steps to reproduce the behavior:

  1. Go to the ballots page
  2. Click on Create a poll
  3. Click on the Cancel button of the form
  4. See all form validations

Expected behavior
The form modal is closed

Screenshots
Screen Shot 2022-09-06 at 10 12 31

Need to Know Where to Put Arbitration / Resolve Links in Navigation Bar

Is your feature request related to a problem? Please describe.
Not sure where I can put the links in the navbar for the upcoming arbitration portal

Describe the solution you'd like
Either add a navigation bar item for "Resolve" or create a new navbar item that is a dropdown where additional modules can include links

Describe alternatives you've considered
n/a

Additional context
n/a

image

Active filtering needs to be reviewed

Is your feature request related to a problem? Please describe.
We need to investigate the active filtering since there may not be reliable metadata that we can use it.

Describe the solution you'd like
We want to see all active ballots when the active filter is selected.

Describe alternatives you've considered
Filter the ballots by the end date being later than the current date.

Show which accounts have voted and how much their vote weight is

For both in progress and completed ballots, we should show which accounts voted and what their vote was, as well as their vote weight. The vote weight we should maybe show as a % of the total. So if one account voted with 100 vote weight and there are 1000 total tokens that have voted, we'd show 10%.

Treasury list empty when creating a ballot

Describe the bug
When creating a new poll, the treasury that my account is registered to does not appear on the list.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you're registered in at least one group
  2. Go to the ballots page
  3. Click on create new ballot
  4. Click on treasury
  5. See that no treasury is listed

Expected behavior
The treasury should show a dropdown containing all the groups your account is registered to.

Additional context
This was fixed in the previous codebase.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.