telenko / node-mf Goto Github PK

This is remote's webpack config

This is host's webpack config

when i build server code with @telenko/node-mf, there will be an error Error: Shared module is not available for eager consumption 694

when passing larger chunks, sometimes the http request fails to reconstruct a readable stream back together.
If i use node-fetch, it seems to be a little more reliable in fetching text and executing it afterwards

Have you explored using this with angular universal and express? Lack of SSR support is the one thing stopping us from using module federation.

Hello,

First, thank you for you work, that is great 👏

Do you think NodeAsyncHttpRuntime could be made easily compatible with NextJS in case we want to use NextJS to both expose and consume modules that will be rendered on server side?

the line 205 in ReadFileChunkLoadingRuntimeModule.js should be changed to:
`rpcLoad( promiseBaseURI ? await promiseBaseURI : baseURI }, ${

Getting Error: Chunk format can't be selected by default when no target is specified when setting target to false and use NodeAsyncHttpRuntime plugin

I took example code and tried to modify the component, but after I did it I get such an error

webpack-cli] TypeError: The 'compilation' argument must be an instance of Compilation at getCompilationHooks (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/@telenko/node-mf/node_modules/webpack/lib/javascript/JavascriptModulesPlugin.js:125:10) at /Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/@telenko/node-mf/node_modules/webpack/lib/javascript/CommonJsChunkFormatPlugin.js:43:19 at Hook.eval [as call] (eval at create (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1) at Hook.CALL_DELEGATE [as _call] (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/tapable/lib/Hook.js:14:14) at Compiler.newCompilation (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/webpack/lib/Compiler.js:1043:30) at /Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/webpack/lib/Compiler.js:1088:29 at Hook.eval [as callAsync] (eval at create (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1) at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/tapable/lib/Hook.js:18:14) at Compiler.compile (/Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/webpack/lib/Compiler.js:1083:28) at /Users/artemyeldinov/Documents/ProjectsEpam/kf-ng-web-light/node_modules/webpack/lib/Compiler.js:508:12 error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I ran into this issue when cloning the example repo + running through the readme steps.

tried with:
node v14.19.0 (npm v6.14.16)
node v16.5.0 (npm v7.19.1)

npm list dumps:
host:

[email protected]
├── @telenko/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

remote:

[email protected]
├── @babel/[email protected]
├── @babel/[email protected]
├── @material-ui/[email protected]
├── @telenko/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

@telenko any insights or ideas what I might have wrong here?

Hi there, thank you for the work you've done putting this together. I was just wondering if you've run into issues where your Next.js app gets "stuck" with an outdated remote via SSR?

For example:

• website 1 (Next.js) consumes a remote
• website 2 (remote) exposes a module

Scenario:

• Both sites build / deploy
• Website 2 makes a change to its exposed component, then rebuilds / redeploys
• Changes are not reflected on website 1 via SSR (changes become visible on client - after some flickering)

I have checked the source code at Line 220 in LoadFileChunkLoadingRuntimeModule.js

require("../hmr/JavascriptHotModuleReplacement.runtime.js")

But I cannot find the required file in this relative path. Do we miss it? thank you.

Is there a way to generate code which is compatible with ES5?
Currently the code generated by the plugin uses require to link http(s), vm, etc. even when module output is explicitly enabled (output.module, experiments.outputModule, output.libraryTarget, output.chunkFormat, etc.). I believe that it is not a correct behaviour, as require is not available in the module context.
On top of that, the plugin also uses exports, __dirname and similar globals, which is also problematic.

The reason that modules support is needed is that new Nuxt 3 uses modules output format and our company is interested in integrating Nuxt and Module Federation.
I am willing to work on adding this feature to the plugin if my help is needed.