current prop(found it in storybook about ScaleSidebarNav) is misbehaving. Even if

Hi Barbora, The current prop's expected type is <code class="notrans

ScaleSidebarNavItem current prop issue(React) about scale HOT 2 CLOSED

telekom commented on May 24, 2024

ScaleSidebarNavItem current prop issue(React)

from scale.

Comments (2)

nowseemee commented on May 24, 2024

Hi Barbora,

The current prop's expected type is string or null.

From the readme:

Property	Attribute	Description	Type	Default
`active`	`active`	Text gets the active color	`boolean`	`false`
`bold`	`bold`	Bold text	`boolean`	`false`
`condensed`	`condensed`	Used normally for third level items, remove the bottom border	`boolean`	`false`
`current`	`current`	Mark the child link as "current" with `aria-current=page`. Provide the text hint if needed, default is: "Zurzeit aktiv"	`string`	`null`
`nestingLevel`	`nesting-level`	Nesting level within the parent, gets set automatically	`number`	`undefined`
`styles`	`styles`	(optional) Extra styles	`string`	`undefined`

https://github.com/telekom/scale/tree/main/packages/components/src/components/sidebar-nav-item

And you are right, it should handle false since that is allowed by the ARIA specs: https://www.w3.org/TR/wai-aria-1.1/#aria-current

... so I'll leave this ticket open until we extend the allowed types but for the time being you could pass '' or null instead of false for a quick fix. I'll come back to you once a patch is released.

Thanks for reporting this issue.

from scale.

nowseemee commented on May 24, 2024

With the latest release (3.0.0-beta.9) it should handle boolean values well 🤞🏻

from scale.

Recommend Projects