Giter Club home page Giter Club logo

Comments (5)

felix-ico avatar felix-ico commented on September 23, 2024 1

hey @tshimber, looks like i forgot to remove the language attribute from the footer, so that's why you were getting the warnings. The header should not throw any warnings though. Normally we wouldn't push updates to deprecated components but this was simple enough to do #2183

from scale.

felix-ico avatar felix-ico commented on September 23, 2024

Hi @tshimber, sorry for the late reply. I understand these deprecation warnings can be annoying and i opened a PR to remove the default language that is set on the logo component (causing the deprecation warning even when the end user doesn't set any language).

By the way I notice that you are using scale-app-shell and scale-app-footer, just FYI these components have been deprecated, and replaced by scale-telekom-app-shell, scale-telekom-footer and scale-telekom-header.

from scale.

tshimber avatar tshimber commented on September 23, 2024

Hi @felix-ico
not so late honestly) thanks for answering!!
thank you, will be good not to have those notifications, but it's not critical of course.
considering deprecated components - we just use them in lots of templates for diff frameworks, need to make a task to update everywhere🙃

from scale.

tshimber avatar tshimber commented on September 23, 2024

@felix-ico Felix, hi! sorry to bother you again, maybe you can tell: how can I get, if thing is or isn't fixed without bothering you? I've updated Scale to latest 3.0.0-beta.142, but I still see the warning. I use deprecated scale-app-shell, as you correctly noticed, but your comment looked like it will be fixed for old ones as well.
It's not critical, but just for me to understand if it will be fixed for deprecated scale-app-shell and to move or don't move it from my list)

Thanks!!

from scale.

tshimber avatar tshimber commented on September 23, 2024

☺☺☺ so nice from you:) thanks a lot!!

from scale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.