tehstoneman / betterstoragetoo Goto Github PK

My friend is having a problem joining a world/server
His error was, "Registry Object not present: betterstorage:cardboard_box" and
"Registry Object no present: betterstorage:reinforced_chest"

Currently, when picking up any of the storage blocks using CarryOn, double-chests and double-lockers do not register that they've been disconnected, and one chest retains the model while the other is invisible.

There's also now a crash when trying to interact with chests or lockers that have been separated like that:
https://paste.dimdev.org/ekebajujic.mccrash

Placing and using lockers works fine. But whenever I mine/remove lockers with a tool or by hand, minecraft crashes. Any interpretation/suggestion helps. :) Let me know if there is any other information I can provide.

https://pastebin.com/a80X5uqH

While the vanilla are most definitely going to be used, the truth is some (like Zinc) usually don't have a way of obtaining in Survival. As a solution for this, I thought of two (or three?) possible approaches:

1, Apply oreDict detection: If a mod adds the block_____ (e.g. blockCopper) material, then BS adds the corresponding reinforced chest/locker.
2. Have a list of materials in the config file. By default it includes all the current ones, but a player/modpack dev can remove those he considers unneeded.
3. Ok, this might be a bit more complicated, as it would involve a mix of the previous two ideas. On one side, you'd have the list of materials, named with oredict entries like blockCopper. When the mod loads, if said oreDict entry was registered by some mod, then it'll add a locker variant for that material. And the metal border would take the texture of the used block, in case more than one mod registers said metal block. This is inspired in Tinkers Construct way of handling the Tool Forge's legs, as a note.

Hello,

We are playing a custom modpack with some of my friend. Some of them crash when they died. The crash report is a little bit curious as the Exeption Throw come from one of Better Storage Too class:

crash-2018-11-15_16.16.09-client.txt

I don't really know if your mod is involded in this crash but I ask in case of it is. We are using Corail Tombstone and Player Revive that could modify some code while dying.

Sincerely,

Sablam

Hello!
Thank you for bringing this mod to 1.12.2!
I would like to get this mod into my current modpack but am having issues with it and Simple Storage network (https://minecraft.curseforge.com/projects/simple-storage-network).

Fist things first, the Storage Link cables do not connect to the reinforced chest, nor any version of the storage lockers. Storage link cables do connect to the storage crate.

However this brings me to the second issue. If the Simple Storage Network is connected to a multi block crate, I get this crash when attempting to access the Network.
https://pastebin.com/wKXtdZND

Forge:14.23.4.2760.
Simple Storage Network: 1.4.0
Better Storage Too:3.0.0.0

When I tried to update the mod on my server I lost connection when I try to login and I searched at the console and it says this:

[23Nov2019 02:26:16.491] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_gold' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.491] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_iron' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.491] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_steel' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_silver' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_copper' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_tin' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_emerald' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_zinc' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:16.507] [Server thread/WARN] [net.minecraft.advancements.PlayerAdvancements/]: Ignored advancement 'betterstorage:recipes/reinforced_chest_diamond' in progress file ./world/advancements/2d2b3a7d-ed16-3ec7-bc19-ac542411896b.json - it doesn't exist anymore?
[23Nov2019 02:26:17.346] [Server thread/INFO] [net.minecraft.server.management.PlayerList/]: Darkness2796[/187.189.49.39:29086] logged in with entity id 124 at (-135.5, 146.05, 385.5)
[23Nov2019 02:26:17.532] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer/]: Darkness2796 joined the game
[23Nov2019 02:26:17.579] [Netty Epoll Server IO #4/ERROR] [net.minecraft.network.NettyPacketEncoder/]: java.lang.NullPointerException
[23Nov2019 02:26:17.619] [Netty Epoll Server IO #4/ERROR] [net.minecraft.command.arguments.ArgumentTypes/]: Could not serialize net.minecraftforge.server.command.ModIdArgument@77812966 (class net.minecraftforge.server.command.ModIdArgument) - will not be sent to client!
[23Nov2019 02:26:17.620] [Netty Epoll Server IO #4/ERROR] [net.minecraft.command.arguments.ArgumentTypes/]: Could not serialize net.minecraftforge.server.command.EnumArgument@5fb3c7f2 (class net.minecraftforge.server.command.EnumArgument) - will not be sent to client!
[23Nov2019 02:26:17.949] [Server thread/INFO] [Waila/]: Syncing config to Darkness2796 (2d2b3a7d-ed16-3ec7-bc19-ac542411896b)
[23Nov2019 02:26:18.147] [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: Darkness2796 lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException
[23Nov2019 02:26:18.148] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer/]: Darkness2796 left the game

Minecraft v1.14.4
Forge v28.2.0
Better Storage Too v4.1.0.0

• Item tooltips in Better Storage's GUIs render below JEI items.
• The GUI background also doesn't get darker because GuiScreenEvent.BackgroundDrawnEvent isn't called, which would prevent the above issue. A comment from mezz confirms this at CreativeMD/LittleTiles#217.

Ugh so there is a glitch is when you die the storage separated and makes you lose all of your stuff in it like ALL OF IT

Some sides of a locker appear very dark when next to another block.
BetterStorageToo-1.12.2-3.0.0.2.jar

All of the mods for 1.12.2 forge I have including BetterStorageToo:
DamageIndicatorsMod
Advent of Ascension
ArchitectureCraft
BiblioCraft
BiomesOPlenty
Chisel with CTM
ChiselsAndBits
VoxelMap with CodeChickenLib
GraveStone
Hwyla
Walia-Harvestability
Just Enough Items
Not Enough Items
McPaint
Natura
Optifine
Tinker's Construct with Mantle
WearableBackpacks

In 1.16.5 the Reinforced Chest appears to be missing its texture.

Currently the cardboard box tools + slime buckets show up in every creative menu tab (including the trash can slot).

To fix that, you just need to wrap the getSubItems stuff into if(isInCreativeTab(tab)) { } and that should get rid of it :)

Hey
I found a bug. When a block gets from the Storage crate structure with the help of CarryOn, it is linked with a large structure.

Crash when interacting with related unit
https://pastebin.com/5cNKW8QQ

Being so used to mods like iron chests, I was kind of surprised to find that all reinforced lockers, whether they cost a few copper, or a block and a half of diamonds, have the same storage size.
Would you consider some more tiers? Right now, I'm playing with Get Ya Tanks Here and you can script the size of the tank (4^tier buckets) and the material (the frame is made from that material). I think something like that would be great. (I must have an OP, star-metal locker. 😄)

It'd be really nice to be able to disable things from this mod. I have no desire to have ten new enchantments showing up on my enchanting table, I don't need cardboard tools, and I don't know why the block of flint even exists.

Please allow us to disable these things without resorting to CraftTweaker.

http://www.minecraftforum.net/topic/1548203-/
says "forbidden" when I click this link

Useless crashlog-
https://paste.fedoraproject.org/paste/uPCtQP~q0hMEhTFk1g7NnA

useful stacktrace in the console-
https://gist.github.com/ProsperCraft/d85e22d285545b24b05af6ca5f2b024a

BetterStorageToo-1.16.5-6.1.1.0
create-mc1.16.5_v0.3.2f
flywheel-1.16-0.2.4

Lets see two gifs:

I don’t know which mod the problem is, so I send the problem to you first.

Running BST 3.0.0.2 and Forge 2776

https://pastebin.com/bP9n2Pcs

The crash seems to happen when visiting a certain area of the map, which is approx 500 blocks away from where the crate is actually located. Once I got the crash, it was happening anytime I logged in. I restored a backup from a few days back and everything seemed fine until I visited the same location on the map.

Thanks!

You have changed the copyright owner on the LICENSE file in this repository.

Notice that the license states:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

If you fork an MIT-licensed project, you may not change the existing copyright notice - you may only append your own, to cover your additions to said code, but you cannot just remove the existing copyright owner from the LICENSE file.

I get this error on our server while trying to break a gold reinforced chest.

[16:00:04] [Server thread/FATAL]: Error executing task[16:00:04] [Server thread/FATAL]: Error executing taskjava.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: net/minecraft/client/Minecraft at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_151] at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_151] at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?] at java.lang.Thread.run(Unknown Source) [?:1.8.0_151]Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/Minecraft at io.github.tehstoneman.betterstorage.utils.WorldUtils.rayTrace(WorldUtils.java:190) ~[WorldUtils.class:?] at io.github.tehstoneman.betterstorage.common.block.BlockLockable.func_180649_a(BlockLockable.java:171) ~[BlockLockable.class:?] at net.minecraft.server.management.PlayerInteractionManager.func_180784_a(PlayerInteractionManager.java:196) ~[lv.class:?] at net.minecraft.network.NetHandlerPlayServer.func_147345_a(NetHandlerPlayServer.java:631) ~[me.class:?] at net.minecraft.network.play.client.CPacketPlayerDigging.func_148833_a(SourceFile:40) ~[ja.class:?] at net.minecraft.network.play.client.CPacketPlayerDigging.func_148833_a(SourceFile:10) ~[ja.class:?] at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[fl$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_151] at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_151] at net.minecraft.util.Util.func_181617_a(SourceFile:45) ~[h.class:?] ... 5 more

Tested on Forge 2281, v1.0.0.0 of the mod. Placing a lock on a chest doesn't remove it from your inventory. So, when you remove it from the chest when sneak-rightclicking with the key, you get a duplicate lock.

Version: 4.0.0.0

Crash Report

To put the error simply, "Provider io.github.tehstoneman.betterstorage.common.inventory.KeyringCapabilityProvider.getCapability() returned null; return LazyOptional.empty() instead!" I totally understand how confusing LazyOptionals are, and I've done this too!

I'm using a diamond pickaxe axe, so I assume that isn't the issue. When I break any of the chests or lockers (aside from wood) the resulting drop is an iron chest or locker.

Forge 2770 and BetterStorageToo 3.0.02

Also, not sure if I'm just stupid or it's a bug but I can't make the cardboard box do anything. Can't place it or open it while in my hand.

Whenever I try to start up Minecraft 1.14.4 with this mod installed, It crashes. The error is
java.lang.runtimeexception
java.lang.reflect.invocationtargetexception

Not really good with code stuff, could someone help?

I get a weird crash for no reason.

I've disabled the reinforced chests and lockers, as well as all cardboard items (except for the box and cardboard sheet itself)

Report & logattached.

crash-2020-09-30_23.02.59-client.txt

latest.log

When I launch my server, it eventually crashes with this

https://paste.ee/p/bVpdQ

Title. Would be nice.

Again, tested on:

• BST 1.0.0.0
• Forge 2281

1. You cannot place a locker with the handle facing the other way, like in previous versions. Wasn't sure if this was intended or not, so I thought about reporting it just in case 😄

2. Sides of the lockers don't react as solid blocks, like they used to. In the past, the door would also be the only way to access the inventory, but right clicking any of the other sides worked like if the block were a regular solid block (for example, a wooden plank). This allowed one to make a quick area of lockers in no time, instead of having to sneak to place them like with vanilla chests. A mod that does something similar is Storage Drawers, with its... Well, drawers :P

3. A small rendering bug when looking to a locker from certain angles. Only seems to affect 2-block high lockers, single look ok.

It should have its own dedicated sound event instead, which just uses the same sounds.

snip

[22:01:22] [Server thread/FATAL] [ne.mi.fm.ModLoader/LOADING]: Failed to complete lifecycle event CONSTRUCT, 1 errors found
>.... [22:01:22] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception
net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [
BetterStorageToo (betterstorage) has failed to load correctly
§7Attempted to load class net/minecraft/client/world/ClientWorld for invalid dist DEDICATED_SERVER
at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:201) ~[?:?] {re:classloading}
at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:183) ~[?:?] {re:classloading}
at net.minecraftforge.fml.server.ServerModLoader.begin(ServerModLoader.java:45) ~[?:?] {re:classloading}
at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:121) ~[?:?] {re:classloading,pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:598) [?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212] {}

BetterStorageToo-1.14.4-4.1.0.1

Mod version: 1.15.2-5.1.0.0
Forge version: 31.2.31

Although Forge documents model loader registration as supporting ModelRegistryEvent, it is in fact not supported and must be done in FMLClientSetupEvent. Registering during the model registry event results in an exception message to be printed during subsequent resource reloads (e.g. F3+T). See MinecraftForge/MinecraftForge#7178 for reference.

java.lang.IllegalStateException: Can not register model loaders after models have started loading. Please use FMLClientSetupEvent or ModelRegistryEvent to register your loaders.
	at net.minecraftforge.client.model.ModelLoaderRegistry.registerLoader(ModelLoaderRegistry.java:88) ~[?:?] {re:classloading}
	at io.github.tehstoneman.betterstorage.client.ClientSetup.onModelRegistryEvent(ClientSetup.java:90) ~[?:1.15.2-5.1.0.0] {re:classloading}
	at net.minecraftforge.eventbus.ASMEventHandler_20_ClientSetup_onModelRegistryEvent_ModelRegistryEvent.invoke(.dynamic) ~[?:?] {}
	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:80) ~[eventbus-2.2.0-service.jar:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258) ~[eventbus-2.2.0-service.jar:?] {}
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:168) ~[?:31.2] {re:classloading}
	at net.minecraftforge.fml.ModLoader.lambda$null$9(ModLoader.java:158) ~[?:?] {re:classloading}
	at java.util.HashMap.forEach(HashMap.java:1289) ~[?:1.8.0_252] {}
	at net.minecraftforge.fml.ModList.forEachModContainer(ModList.java:218) ~[?:?] {re:classloading}
	at net.minecraftforge.fml.ModLoader.lambda$null$10(ModLoader.java:158) ~[?:?] {re:classloading}
	at net.minecraftforge.fml.client.ClientModLoader.preSidedRunnable(ClientModLoader.java:132) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraftforge.fml.ModLoader.lambda$loadMods$11(ModLoader.java:158) ~[?:?] {re:classloading}
	at net.minecraft.resources.AsyncReloader.func_219557_a(SourceFile:71) ~[?:?] {re:classloading}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] {re:classloading}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:897) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:553) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(SourceFile:204) ~[minecraft-1.15.2-client.jar:?] {re:classloading}
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_252] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_252] {}
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_252] {}
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_252] {}
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.15.2-31.2.31-launcher.jar:31.2] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.1.0.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.1.0.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.1.0.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.1.0.jar:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.1.0.jar:?] {}
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:50) [ForgeWrapper-1.4.2.jar:?] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_252] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_252] {}
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_252] {}
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_252] {}
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?] {}
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?] {}
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] {}
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?] {}

https://pastebin.com/cJ6x0at2

I've been having a good time with BST (interestingly Rustic's cabinet is the same recipe, size, stacking, and has a very similar appearance). The one real problem I'm having is that I can't sort the cabinet or use inventory tweaks' shift-click functionalities to bulk move items. Is there some way to get these two to play together? Thank you.