Limit for "Instructions" field in creating and editing a session not correctly treated. about teammates HOT 6 CLOSED

Hi @pabloheika, I'm inclined to leave this as is since it's very unlikely anyone will enter such long text into the input field (and as far as I'm aware, this poses no security concern). Loading times also seem fine to me, I believe under 10s. Previous data isn't overwritten as well.

Perhaps an improvement to be made is to have a more descriptive error message, rather than impose an arbitrary limit on the text length of the input field. Let's see what others think.

As a quick benchmark, I checked this with 500,000 words for a total of 3,385,396 bytes/characters and didn't get an error. Loading times (rough estimate) were under 5s.

from teammates.

Generally speaking, we would only mark a UI issue as needing fix if it either poses a threat to system stability and/or security or inconvenience to a significant number of users.

• Threat to system stability / security: someone needs to verify the impact of this to the backend, e.g. if it causes a more-than-usual backend processing time, then it is a vector for DDoS attack and thus needing fix. A localized impact on user browser is irrelevant here.
• Inconvenience to a significant number of users: extremely unlikely. The user doing this clearly knows what s/he does.

However, we do need a hard limit on the backend. An unlimited upper bound, even without security concern, would bloat our DB storage cost (I'm not sure if there's a term for this kind of attack). The hard limit can be a sensibly large number such that anything beyond that is clearly an abuse attempt.

from teammates.

What should the word limit be for it?

from teammates.

@wkurniawan07, any suggestions? I would say not more than 500 words, though it might be worth taking a look at how many words are usually used for the instructions field

from teammates.

Hi, I would like to work on this if there is not progress yet.

from teammates.

Hi @rexong, feel free to submit a PR for this issue. As for the max number of characters/words... will leave it up to you for now, just decide on a reasonable amount (:

from teammates.