Comments (10)
hello @jckras feel free to submit a PR!
from teammates.
hi @jckras, do submit a PR to let us do a code review, thank you!
from teammates.
Hi, can I work on this?
from teammates.
Reported by a user. V8.30
Problem: Per-recipient stats are calculated based on student name. When there are multiple students with the same name, their scores are added up. It should be based on student email instead, which is the only field guaranteed to be unique.
A similar problem might be affecting other places too, but this is the one reported by the user. As a temporary workaround, I've asked the used to disambiguate names so that no students have the same name.
Hi @damithc the image that was included with this example does not seem to be a visualization of the problem occurring. Can you please provide clearer details on how to reproduce this issue? Thank you.
from teammates.
@jckras steps required to reproduce the problem:
- Create a course that has multiple students with the same name
- Simulate a session that has a question such as the one given in the screenshot
- View the results (as an instructor) of that session and examine per-recipient stats of students with the same name
from teammates.
@damithc Thank you!
from teammates.
H @damithc, my partner @Hkovin and I have been working on this issue. We looked at somewhat similar issues for guidance such as https://github.com/TEAMMATES/teammates/issues/12125 We suspect that the issue may be coming from how the perRecipientResponses is being implemented in msq-question-statistics-calculation.ts
We are looking here because this is what is used to implement the mcq-msq-question-statistics-calculation.ts
(Multiple choice, multiple select question stat calculations). What are your thoughts on this?
from teammates.
@jckras Thanks for taking an interest in this issue.
What are your thoughts on this?
We can wait to see if other devs have some idea about this specific issue, but normally, it the the PR author's job to find the problem and propose a solution. So, try to come up with a solution that works, and the dev team members can give feedback on your solution.
from teammates.
@damithc Hi, I have a proposed solution for this bug! In the msq-question-statistics.component.ts
file the perRecipientColumnsData object has the header descriptions shown below.
In order to separate responses based on student email, I think I should add another component of the perRecipientColumnsData object that includes the recipient email. After this change, the perRecipientColumnsData object implementation would look like the updated code shown below.
from teammates.
Hi @damithc and @cedricongjh - found the issue, doing testing and submitting a PR this week. Wanted to follow up. Thank you!
from teammates.
Related Issues (20)
- Release V9.0.0-beta.2 HOT 2
- Release V9.0.0-beta.3 HOT 2
- Release V9.0.0-beta.4 HOT 2
- Add documentation for unit tests
- 'Duplicate emails' error while enrolling, although there are no students in the course HOT 1
- Make substrings of the name in dropdown selections of recipient to be searchable HOT 16
- Can we use StringBuffer class instead of StringBuilder? HOT 5
- Release V9.0.0-beta.5 HOT 2
- Use AccountRequestUpdateRequest as parameter HOT 4
- Combine Admin Add Account Request Flow into Instructor Account Request Flow
- Problem with BACK-END TEST SUITES HOT 1
- Add CAPTCHA to Account Request Form HOT 1
- Release V9.0.0-beta.6 HOT 2
- Code Coverage Issue: struggling to pass all tests
- Admin rejecting account request: give actual account in the email template
- Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' HOT 2
- Accounts request form: auto-unify country names HOT 4
- Admin managing account requests: use spinners to indicate actions in progress HOT 4
- IndexOutOfBoundsException encountered by LogsProcessor HOT 2
- Need help with contributing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teammates.