Giter Club home page Giter Club logo

documenter's People

Contributors

davidfirst avatar debs-obrien avatar giladshoham avatar giteden avatar imsnif avatar itaymendel avatar joshk2 avatar kutneruri avatar odedre avatar qballer avatar ranm8 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

ocombe

documenter's Issues

large gap for first header

In some components, we are seeing a large gap in the beginning of the docs.
This is because our headers have a margin-top associated to them.

The margin-top is there to create separation between paragraphs.

image (6)

There are a couple of solutions we can take:

  • disable margin-top for the first header, like so .mdx > { h1, h2, h3, ... { margin-top: 0} }
  • remove margin-top and apply margin-bottom
  • we can intelligently apply a sibling margin, like so p + { h1, h2, h3, ... { margin-top: 40px }}

Also check the case where setting a wrapper component:
Screen Shot 2022-07-17 at 19 00 38

add shadow to copy message

Copy message looks a bit odd when on text.

It's dense and creates a visual load.
Screen Shot 2021-07-27 at 12 36 40

This is not the case without text in the background:
Screen Shot 2021-07-27 at 12 42 32

We can "fix" it by adding a shadow, that will increase the contrast:
Screen Shot 2021-07-27 at 12 38 05
(raised-low shadow)

Screen Shot 2021-07-27 at 12 36 43
(hower-lower shadow)

It also looks good without text in the background:
Screen Shot 2021-07-27 at 12 37 44

max-width causing problems with react playground

max-width: 100% is causing side effects for the react-playground.
I already overridden it for the playground, but it can still effect the html inside the live view.

Screen Shot 2021-07-27 at 16 06 18

We need some escape hatch to exclude it. The original rule is:

.mdxContent {
  * {
    max-width: 100%;
  }
}

maybe we can do something like this instead?

.mdxContent {
  :not(.excludeMdxMaxWidth) *, :not(.excludeMdxMaxWidth) {
    max-width: 100%;
  }
}

We can then apply the excludeMdxMaxWidth class on the playground.

It is generally better to avoid the :not operator, but this is the best I've got.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.