Giter Club home page Giter Club logo

pandas_cub's Introduction

pandas_cub's People

Contributors

tdpetrou avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pandas_cub's Issues

_unicode_to_object test case issue

In test case _unicode_to_object, assert_array_equal doesn't verify the datatypes of arrays.
This code still passes the test case.

def _convert_unicode_to_object(self, data):
	converted_data = {}
	for key, val in data.items():
		if val.dtype.kind == 'U':
			converted_data[key] = data[key]
		else:
			converted_data[key] = data[key]

	return converted_data

Update:
This verifies the type conversion correctly.

def test_unicode_to_object(self):
        a_object = a.astype('O')
        assert df._data['a'].dtype.kind == a_object.dtype.kind
        assert df._data['b'].dtype.kind == b.dtype.kind
        assert df._data['c'].dtype.kind == c.dtype.kind
        assert df._data['d'].dtype.kind == d.dtype.kind
        assert df._data['e'].dtype.kind == e.dtype.kind

Exercise 8 and 9 should be swapped

Exercise 8 involves the uncommenting of the _repr_html_ method. However, this method invokes the self._values attribute, which is only implemented in excercise 9. Hence, completing exercise 8 and trying it out in the notebook results in a AttributeError: 'DataFrame' object has no attribute '_values'. This would be solved by swapping both exercises.

diff is not tested with negative numbers

First of all just wanted to say I think this is a really cool project you've put together, thanks for doing it!

I ran across this issue because I messed up the diff method when I first wrote it, but my tests passed because the test_diff test only tests a shift of 1. It seems like a good idea to test a negative index to get more complete coverage.

On the other hand, I don't know if you are interested in adding more tests to this or not, because that opens a box of lots of potential edge cases to add.

If you're interested in people adding tests I'd be happy to open a PR if that's the route you want to take.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.