tdauth / dmdf Goto Github PK

Since the ASL is not used by any other project, integrate it into this repository.
Drop all unnecessary stuff and just add the source code.

During video sequences the camera zooms in slowly.

Probably caused from timerFunctionCamera.

Even using StopCamera() does not prevent this.

Watch the old Let's Play of version 0.8 to see the bug: https://youtu.be/7KUJztCI9AA?list=PLmfeGbBvSVGCRbNKSk3QOh1v09h6YFyxU&t=2030

The zoom is very slow but if you go forward in the video you will see that the camera distance is smaller.

Wigberht, Ricman, the High Elf etc. should get an inventory where they can use at least potions etc.

Ruft für <A1CZ,Dur1> Sekunden einen Dämon herbei Der beschworene Dämon verbrennt Gegner in seinem Umkreis..|n|cffc3dbffEs kann nur ein Dämonendiener beschworen werden.|r .|n|n|cffffcc00Stufe 1|r - Stufe <n00P,ulev>, verursacht <n00P,ua1b> Schaden und besitzt <n00P,def> Rüstung, <n00P,umpm> Mana und <n00P,uhpm> Leben. |n|cffffcc00Stufe 2|r - Stufe <n03S,ulev>, verursacht <n03S,ua1b> Schaden und besitzt <n03S,udef> Rüstung, <n03S,umpm> Mana und <n03S,uhpm> Leben. |n|cffffcc00Stufe 3|r - Stufe <n03T,ulev>, verursacht <n03T,ua1b> Schaden und besitzt <n03T,udef> Rüstung, <n03T,umpm> Mana und <n03T,uhpm> Leben. |n|cffffcc00Stufe 4|r - Stufe <n03U,ulev>, verursacht <n03U,ua1b> Schaden und besitzt <n03U,udef> Rüstung, <n03U,umpm> Mana und <n03U,uhpm> Leben. |n|cffffcc00Stufe 5|r - Stufe <n03V,ulev>, verursacht <n03V,ua1b> Schaden und besitzt <n03V,udef> Rüstung, <n03V,umpm> Mana und <n03V,uhpm> Leben.

Sometimes when you skip infos.

All abilities in the options spellbook ability should be added directly since they are more important than the others.

German and English versions have 0 values.

Values are mostly 0.

The character walks under the bridges.
See https://www.hiveworkshop.com/threads/advanced-coop-rpg-terrainer-graphics-balancing.260486/page-3#post-3218244

The destructibles do already exist with pathing textures and are walkable. Use them instead of the Doodads with platforms.

The German tooltip uses the wrong ability ID (increased number per level).

Save and optimize the maps and campaigns with the latest patch 1.28.
JNGP2 is deprecated. Use the SharpCraft editor: https://www.hiveworkshop.com/threads/sharpcraft-world-editor-extended-bundle.292127/

Holzbruck does not have configured the correct tilesets. Besides, it does not use the possible maximum of different tilesets.

Changes in the initialization (probably the removal of .evaluate() for initVideo() in the module Video) caused that VideoIntro.video() returns 0 in MapData.start.

The call trace of the initialzation of VideoIntro.m_video (manually detected in the generated output map script):

First initilization in the map script:
* s__VideoIntro_Video___m_video = 0 in the globals block

Call traces reversed:

* s__VideoIntro_create is called from s__VideoIntro_initVideo
* s__VideoIntro_initVideo is called from sa___prototype20_initMapVideos
* sa___prototype20_initMapVideos is a condition AND action of st___prototype20[25]
* sc___prototype20_evaluate(25) is called from sa__MapData_init
* sa__MapData_init is a condition of trigger st__MapData_init
* st__MapData_init is evaluated from sc__MapData_init
* sc__MapData_init is called from s__Game_onInit
* s__Game_onInit is executed from jasshelper__initstructs11557318 (this function has many many calls -> OpLimit?)
* jasshelper__initstructs11557318 is executed from main

The NPC Dararos in the map Talras needs sound recordings.

ASpell allows defining custom conditions in onCastCondition() or via m_castCondition.

Those are checked in triggerConditionChannel of ASpell. If the condition fails the caster is stopped. This should prevent the unit from casting the spell AND using the mana cost. The trigger uses the event EVENT_PLAYER_UNIT_SPELL_CHANNEL.

However the mana cost is used although the unit is stopped and does not cast the spell.

Is this some issue with the event?

For players who don't want to read the whole conversations, add a button which allows getting quests and continuing the game.

Tests with two of the widgetizing programs failed to widgetize Talras. Therefore add widgetizing support to the wc3lib. Widgetize the maps to improve the loading performance.

Besides fix preloading ALL abilities to reduce the lag in the beginning?

The initialization code could also be reduced by dropping unnecessary systems and reducing the code size in general (smaller textmacro containers etc.).

Recent multiplayer tests of the modification (unfinished version 1.0) showed the following bugs:

• multiboard disappears for the players in the class selection if one player changes the class
• FIXED: grimoire spells cannot be skilled higher than level 1 although skill points are used
• after some time of playing some unknown bug occurs (maybe OpLimit) and we cannot continue to play anything -> quest areas don't work anymore -> whenever a character enters a quest area it is counted as 1/n characters although more than one character is in that area
• arena opponents should skill with you in the map Talras
• arena rewards should depend on how strong the opponent is
• if one player skips a sentence in a dialogue with an NPC, the sentences are skipped for other players as well if they talk to the same NPC
• it should always be possible to accept Lothar's quest (even after offending him)
• add "quick quest" buttons for players who don't want to read all dialogues

All tr("") calls have to be replaced by tre("", "") calls.

All trp() calls have to be replaced by trpe() calls.

Extract war3map.wts from "Karte 1 - Talras.w3x" into "maps\Talras" and copy it to the file "war3map_de.wts" and merge it with "war3map_en.wts" but only add new entries and dont overwrite already translated parts.
war3map_en.wts needs to get all translations into English.

Use wc3trans from the project wc3lib to update the translations for all other maps as well since they share most of the object data:

TODO show the calls

Show the XP from the current level to the next and not the total!

Every normal grimoire spell has an ability for every level of the spell to allow using different icons for different levels (with a level symbol on it).
Those icons must be generated from the ReplaceableTextures\CommandButtons\BTNBla.blp file.
A disabled version must be generated as well.

The script "src/Scripts/dmdf-all-grimoire-icons" should generate all those icons from a list of filenames. Afterwards apply them manually or just use a tool for it (a custom object merger).

To use imagemagick (convert) the BLP files must be converted to PNG files and afterwards the PNG files must be converted back to BLP. Use wc3converter for this but at the moment there is a bug when converting BLP files.

On Windows 8 and 10 the executable created with MPQDraft don't work (they don't start or are very slow).

Add another method to inject the MPQ TPoF.mpq when starting The Frozen Throne. One possibility is SharpCraft but a custom plugin is needed since there is no config file to edit.

Another option is to use local files but then all files would have to be moved into a subfolder in the Warcraft III directory (icon paths would have to be changed as well in the game UI settings): http://www.hiveworkshop.com/forums/world-editor-help-zone-98/local-files-107129/

Probably because it is based on an item ability?

He should be restored at some zone position.
The world map needs to be considered for all other maps as well.

• Game options can not be selected after the second transition to a map (recreation of the character).
• FIXED: Since the character is restored at (0 | 0) the player can see that area from the sight range of the game options.
• Although specified the temporary save games folder is not removed in the beginning of Dornheim. Therefore an old version of Talras is loaded (savegame). The folder must cleared manually.

Maybe the trigger "Intro Init" isn't even called.

Although he has only 30.

If there is no music online use Warcraft's themes in video sequences.

Since MPQDraft does not work reliable on all systems and with the latest patch not even on Windows 7, the registry entry Allow Local Files has to be used.
The Power of Fire.exe should enable the registry entry and disable it after exitting.
The folders have to be installed directly into the Warcraft III directory an remove from it on uninstalling them.
A better solution would be to place symbolic links but it may not work with .lnk names.

Can't teleport together with fellows to a shrine (not even alone!).

Allow specifying the start position in the map settings.

0 damage for the spawned demons.

Most of the code is already there but traveling with fellows could also be useful?

Since the map is based on GUI triggers only, remove its code from the repository.

Add scrolls of healing to the map Talras which can be bought from Irmina or Sisgard.

Only 0 values and too many dots (learning tooltip).

Find the source of this problem.
See https://www.hiveworkshop.com/threads/advanced-coop-rpg-terrainer-graphics-balancing.260486/page-3#post-3218244

When traveling from Dornheim to Talras and back to Dornheim, the equipment is not restored.
The inventory is empty.
Therefore, the restoring of the inventory does not work when loading a map.