tbrd / flight-hogan Goto Github PK

This component requires hogan but then assumes that a global Hogan is available.

Would it be possible to change this to var Hogan = require('hoganjs')? I'm using Webpack right now so can map hoganjs to hogan.js (from npm) and AMD users can do a similar thing with the config options. Both routes also allow the global Hogan to be returned if someone is using it that way.

Thoughts?

I'm not sure what the purpose of the standalone hogan component is. Could you just move all the code into with_hogan and mixin in to whatever component needs it?

You need to tag the commit that bumped v0.0.1: git tag -m "0.0.1" 0.0.1

And then push it to GitHub: git push --tags origin master.

Then people using Bower will be able to install specific versions.

The current tagged version, default install with Bower, is old and the path to Hogan is off.

Using the version in the master branch works great so I'm currently tracking that commit in my bower.json.

Thansk in advance!

It's a little confusing to have a file called hogan.js both in the Hogan package and this one. Not sure what a good name would be, maybe something like hogan_helper.js.

The paths to Hogan in the hogan.js module shouldn't include bower_components. You should add a path to the test-main.js file that maps Hogan's installed location to the name hogan, as we do with flight.

Also, the files you're referencing are CommonJS not AMD, so they won't work. For the moment, you need to point to a web build in the Hogan package.