tatey / delayed-web Goto Github PK

Would this project be interested in a PR that paginates the jobs list? It would include a pagination gem.

Since one presumably would never want just any member of the public to be able to access the /jobs and /job/:id routes, what is the best practice for limiting access to admins when using either devise or pundit?

I was successfully able to override the controller as shown below by placing a copy of the controller in app/controllers/devise/web/jobs_controller.rb and verified with a couple of puts statements that THIS controller is being invoked.

But I cannot see how to apply authorization logic.

Using the usual Devise approach I tried before_action :authenticate_admin! but that gave an undefined symbol error. As did the usual Pundit approach after_filter :verify_authorized

I also tried inserting a

redirect_to my_app_home_path and return if !current_admin

but it does not redirect (it does recognize the value of current_admin , but the redirect "out" to the main app's routes doesn't happen

 class Delayed::Web::JobsController < Delayed::Web::ApplicationController
      # WHAT GOES HERE?
      # error, undefined, for devise:   before_action :authenticate_admin!
      # error, undefined, for pundit:   after_filter :verify_authorized
   def queue
     ...
   end
 
   ...
 

When one is not using the asset pipeline the Engine's stylesheet does not get rendered. Your check here is checking Rails' generator options, not the project's config -I believe. So in most (all?) cases the statement evals to true.

If one is not using the pipeline the /stylesheets/delayed/web/application.css will be empty.

Hello,
just tried to work with delayed-web, and it's not installing when running "bundle install".
I'm working on rails 5

Default i18n file:

pt-BR:
  delayed/web:
    views:
      id:
      job:
      jobs:
      status:
      created_at:
      run_at:
      attempts:
      last_error:
      server_time:
      handler:
      actions:
      current_queue:
      buttons:
        run_next:
        delete:
      queue:
        empty:
      errors:
        empty:
      statuses:
        executing:
        failed:
        queued:
      confirm:
        delete:
    flashes:
      jobs:
        queued:
          alert:
          notice:
        destroyed:
          alert:
          notice:

  time:
    formats:
      short:

Much work to get this working?

Using this gem from the github repo with 4.2 and it works great, but I'm a bit confused by the rubygems version:

https://rubygems.org/gems/delayed-web

That indicates 0.2.0, while this repo is 0.0.1?

I just discovered that the link used to show the full set of I18n translations available in the README is redirecting to my own fork (and wrong branch) instead of yours.

You can find the full list here. 
# => should redirect to https://github.com/thebestday/delayed-web/blob/master/config/locales/en.yml

Sorry for this mistake 😕

I have delyed_web installed in a Rails 6 API only app. I get the following errors when I go to http://localhost:3000/jobs:

ActionView::Template::Error: link_tree argument must be a directory

and

no implicit conversion of nil into Array

Any idea why this is happening? Are the directories I need to manually add or should I change my app/assets/config/manifest.js file? This is what it looks like:

//= link_tree ../fonts
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css

The error is happening in: Delayed::Web::JobsController#index

That could be a good idea to add an I18n support in order to translate table columns, actions or messages !
Is there a way to add it easily ?

Thanks for this gem !

Run Next
ActionController::RoutingError: No route matches [POST] "/jobs/jobs/xxxx/queue

Delete
ActionController::RoutingError: No route matches [POST] "/jobs/jobs/xxxx

Ruby: 2.4.0
Rails: 5.0.3

Project is configured as API only with some gems added back for some frontend work

I am getting a bundle conflict due to delayed-web's rails (< 4.3.0, >= 3.2.13) requirement on Rails 5.0.0.rc1

I switched from delayed_job_web to this gem for a variety of reasons, and the one thing that I miss is some summary of how many jobs are queued up. When there are a lot, there isn't any pagination even, so it's unclear from the interface how many there are.

Any thoughts on adding that?