Giter Club home page Giter Club logo

mharmory's People

Contributors

dependabot[bot] avatar lyuha avatar tanukisharp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

mharmory's Issues

Missing search results in 0.8.4

I noticed that upon upgrading from 0.8.2 to 0.8.4 some search results went missing. Here is an example, taken from 0.8.2, both overrides being off:

Missing result:
mssingresult

This result doesn't appear in 0.8.4 anymore, and is perfectly valid. I've found that this is because Empress Coil B doesn't get elected for the search. Here is a before and after:

0.8.2:
before

0.8.4:
after

As you can see, there are other changes as well. I believe there is some incorrectness in the piece election algorithm. The Empress Coil gives only Tool Specialist, so I suppose because of that the election algorithm discards it, but in the end it does end up being a viable solution. I'm not entirely sure how to solve this, I'll try to give it some thought.

Event Quest Window Removal

Removal of the events quest window makes it significantly more difficult for PC Users to do armor set searches with only what has been released on PC, before I could just turn off the events that have not been released, now I have to go through and search for every piece of armor in the armor override that has not been released for PC yet and disable it, this may be more accurate, but it still feels like removed functionality

Suggestion: skill exclusions

For example, I have a melee weapon with hidden element and I want to use Non-Elemental Boost. This means that I don't want to see any build with Free Elem/Ammo Up (as it would nullify Non-Elemental Boost) , so it would be nice to exclude sets that have that.

Add Weapon/Weapon Info to Builds

Maybe it's beyond the scope of this project, but I really think it would be nice if "effective raw" computations were added to the sets that are built. This would necessitate adding a way to allow the user to select the weapon of their choice; but you already have weapon data in the app itself (minus ATKT weapons?).

HoneyHunterWorld has done a good job IMO with including this values (EFR) and it really does allow you to min/max your builds because you can see what truly maximizes your attack values.

Toggling any setting resets advanced search

  1. set up an advanced search
  2. toggle Decorations override or rarity or gender or weapon slots
  3. advanced search settings have been overriden to the defaults

(also, it would be nice if the program saved advanced search parameters, as well as a toggle to reset parameters to default)

Search optimization

Okay I'm back with an example where a search that should give result but instead gave nothing.
image
Here we are searching for
Botanist Lv3 Detector Lv1 Forager’s Luck Lv1 Geologist Lv3 Intimidator Lv3 Master Gatherer Lv1 Scent Hound Lv1 Scholar Lv1 Tool Specialist Lv3 Effluvial Expert Lv1 Heat Guard Lv1
This should give exactly 1 match given restrictions on PC sets (excluding Drachen a, Kush y, Kaiser y, Zorah y, Xeno y, Luna y, spring event, summer event, Azure Starlord a...)
as found by http://mhw.wiki-db.com
image

System.IO.FileNotFoundException

Date: 12/13/2018 2:11:54 AM -06:00
Version: 0.0.8.0
CurrentCulture: en-US
CurrentUICulture: en-US
GitBranch: master
GitCommitHash: 84f7c4b
GitRepository: [email protected]:TanukiSharp/MHArmory.git

System.Windows.Markup.XamlParseException: 'The invocation of the constructor on type 'MHArmory.MainWindow' that matches the specified binding constraints threw an exception.' Line number '6' and line position '9'. ---> System.TypeInitializationException: The type initializer for 'MHArmory.AutoUpdate.AutoUpdater' threw an exception. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

2018-12-13_08-11-54_987.log

I have .Net Framework 4.7.2 installed.

Resetting decorations/equipment override

Currently the "Activate" checkbox allows you to quickly switch between armor pieces that you have and all armor available. That would be fine, except that the tool currently lists drachen armor, while Behemoth is not available for PC yet. So to search everything except drachen, since I've imported my save, I have to go to equipment setup and click on all armors/charms sets that I don't own in order to enable them.

A simple solution would be a "Select All" / "Deselect all" button, which would reset the configuration quickly, allowing you to quickly disable one or two specific sets.

Kulve armor

Just want to mention that armor value for all of Kulve's gear is 92. Cheers.

Lunastra Gamma

Lunastra's Gamma gear is currently together with the alpha and beta sets if the box is checked in the Events window. It should be separated out as the Gamma set is from AT Lunastra.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.