tannerjt / classybrew Goto Github PK

When the evaluation of the values array finds fewer ranges than the number of classes specified, the range array is filled at the lower end with zeroes. This causes the getColorInRange function to return erroneous results ("undefined" and "false") when the value of the num provided to it is zero. This is because the test for this.range[i + 1] (to see if it exists) produces false because the value in this.range[i + 1] is zero, which is the same as false. Correcting the test to this.range[i + 1] !== "undefined" fixes the problem, but still causes num of zero to select something other than the very first color.

Example:
numClasses = 6
brew.classify() = [0, 0, 0, 5859, 102141, 198942, 378736]
brew.getColors() = [color1, color2, color3, color4, color5, color6]
brew.getColorInRange(0) = color3

Webpack can't find classybrew module in my project. Looks like the problem is missing definition of an entry point of your module in package.json:

...
"main": "build/classybrew.min.js",
...

By the way, repository attribute is incorrect, too.

In this line in the second condition you want to check that i+1 < length. But if one of breaks is exactly equal to zero, this check will fail (and lalse will be returned).

Maybe, just check i+1 < this.range.length?