Support for File about lumi HOT 7 OPEN

@Tanmoy741127 , about your first point: would it be possible to use Path objects to serve files/folders to the user? I imagine something like this would be useful:

from pathlib import Path

def get_file(name) -> Path:
    return Path(name)

from lumi.

@dosisod working on that. User can return an instance of file like you show.

from lumi.

@dosisod added support for serve filesin latest version. Check the README file. Give it a try and provide feedback please.

from lumi.

Will do! I'll take a look at it in the next couple of days

from lumi.

@dosisod sure

from lumi.

.

from lumi.

Sorry for the delay on this! A couple notes:

1. Files passed to open() should be checked to ensure that they are from inside the directory Lumi is being ran in. If this isn't checked, somebody could steal files from anywhere on the file system:

from lumi import Lumi

def index(file: str):
    return open(file)

$ curl -X POST localhost:8080/index -d '{"file":"/home/user/.ssh/id_rsa"}' -H "Content-Type: application/json"
<RSA KEY>

You can check this with the following:

from pathlib import Path

if Path("some/file/name").is_relative_to(Path.cwd()):
    # handle file
else:
    # return 403 or 404 error

2. In the README you use the rb mode to open the file. Is there any difference between r (the default) and rb? I didn't see a difference in my testing.

Thanks!

from lumi.