tandav / musiclib Goto Github PK

4/2 means there are 2 whole notes in a bar (not 1 as on 4/4)

maybe this will be confusing notation (whole note no more means 1 bar)

seems like denominator is powrs of 2:

Any time signature can be used, provided it has a numerator between 1 and 99 and a denominator with a beat value of 1, 2, 4, 8 or 16.
https://www.ableton.com/en/manual/session-view/#tracks-and-scenes

maybe this is all useless because note durations in MIDI file are represented by on/off ticks, not by fractions (1,1/2,1/4 etc)

• inherit Chord(Notes)
• inherit Scale(Notes)
• musictools.scale.Scale should be DiatonicScale(Scale) ???

https://github.com/tandav/musictool/blob/master/musictool/chord.py#L47

schema:

• chord a (str) (eg C3_G5_C6_E7/C)
• chord b (str)
• check function name (str)
• return (bool)

function checks table:

• check function name (str)
• function code (str)
• sha? md5?

https://github.com/tandav/musictool/blob/master/musictool/voice_leading/checks.py#L64

https://github.com/tandav/musictool/blob/master/musictool/chord.py#L48

it should support not only -1 but also -2, -3, .. -n. candidate_constraint is not good for this because it difficult to handle loop=True case. So general curr_prev_constraint is required , it should support loop=True

https://github.com/tandav/musictools/blob/master/musictools/notes.py#L50

sequence_builder(
    ...
    curr_prev_constraint={-1: no_bad_checks, -2: lambda a, b: not equal_roots(a, b)},
    loop=True,
)

gives this False positive exmple: EDFECD (second D has -2 root == D)
full chords:

[E1_B1_D2_G2_E3/E, D1_C2_F2_A2_C3/D, F1_C2_F2_A2_E3/F, E1_D2_G2_B2_E3/E, C1_C2_E2_B2_G3/C, D1_C2_F2_A2_F3/D]

Also remove /refactor chromatic.iterate

Use it for everlasting video

• Add access to prefix in sequence_builder constraints
  For example to check that -1, -2, -3 root notes are not equal to current
• #66
• more tests
  • test unique and parallel (theres frozenset usage inside)
• feature: take callable which generates options for each step. (now you can only iterate through every possible options)
  pass args to that callable
• upgrade to class
  classmethods for different scenarios: options is iterable, iterable of iterables, callable
• add caching
  • profile cache, is it used in my algo, maybe computing permutations-like sequences didn't use cache (waste of RAM)
  • its kinda not used (ensure this is not because of some stupid bug) sequence_builder.cache_info(): CacheInfo(hits=0, misses=1397182, maxsize=None, currsize=1397182)
  • maybe some parts of the build / constraint checks can be cached
• parallel computing
  • test that parallel results are equal to single threaded
  • paralellize sequence_builder (multiprocessing), make an api to compute on server
  • #65
• fix #49
• tqdm progressbar
• use iter, next for SequenceBuilder

https://github.com/tandav/musictool/blob/master/musictool/voice_leading/progression.py#L229

Test it

• grep for usages in jupyter notebooks

• encode / for server urls with .replace('/', '__') and .replace('__', '/')
• make repr cached property

• add test to check cache is used
• use Progression.transpose_unique_key as helper (rewrite it, update tests)