Hello,

I really enjoy this application, but I noticed an error with the way some posts are rendered.

Check out this post:

http://reddit.com/r/WeAreTheMusicMakers/comments/a7wmz/heres_a_picture_of_me_in_my_studio_anyone_else/

When viewed from within 'reddit is fun', many posts with links are truncated in strange places -- notably, one by user locutor and one by user robhutten.

I've only just now noticed this phenomenon, but I can recall many other instances where people had links in their posts and referred to something like "the third link", which only confused me.

Any thoughts? Thanks for writing this app, by the way -- it's a real lifesaver. The m.reddit.com site was my previous way to check reddit on the go.

I do not currently label the OP, mods, admins in comments list. I don't know if the info for mods/admins is in JSON. Of course the OP can be found by looking at the OP ThreadInfo.

I wasn't sure about this though, since I know some subreddits can disable it (and maybe for good reason).

Related: /r/TRUST blacks out everyone's name by default. How to handle stuff like that?

I think this will make things more responsive and reduce problems caused by task switching.

Also may reduce Browser CPU problems (see "Browser CPU usage" bug: http://github.com/talklittle/reddit-is-fun/issues/#issue/14)

as of version 0.8.6 the app is 500kb. I think lots of code can be refactored to reduce code size by almost 50%

Some people have asked for the option to skip the popup and have option to always do one of:

• goto link
• goto comments
• toggle vote

Need a way to specify font size in Settings

How to recreate:
-start up a reply

-rotate screen after entering reply

-attempt to submit

Upon submitting, I get a Toast error and then when I try to cancel the reply, the program force closes.

You should be able to do a find on the current comments list and jump to the next comment containing that character string.

Want to add markdown capability for monospace (lines preceded w/ 4 spaces)

One reason: for QR codes produced by http://asciiqr.com/

Long threads can get hard to follow, in a browser one can click the "Parent" button on a comment to see the initial comment that it was a reply to. A similar ability in this app would be extremely handy.

using trackball you cannot reach the <next 25> button. Instead it simply highlights the field as if it was another story. Eg.

[Story 23]
[Story 24]
[..(next 25)..]

highlights the '[....]' section beneath the button

Currently it is only possible to edit your subreddit list using the browser by editing your "my reddits" list. It would be convenient to be able to modify the list directly in the app. This requires an activity (either existing PickSubredditActivity or a new one) to use JSON instead of current HTML scraping, so that we can determine the subreddit id36 to pass to API via POST.

Alternatively, there could be a separate offline data store, and the list that the user sees is the union of both lists.

http://www.reddit.com/r/Android/comments/bmxxr/a_few_reddit_is_fun_thoughts/

Apparently people have issues with light theme on Verizon Droid phone. I think that means android version 2.0.

So, need to check compatibility with different screen sizes.

Want ability to scroll the list views using volume slider.

Right now the current theme is checked in many places in the code, which assume there are only a "light" and "dark" theme. I'd prefer if it supported a variable number of themes. And maybe themes should be addable (downloadable?) and removable.

"""Hello I've been using your app on my htc magic for a while and have recently upgraded to android 1.6. Since then I have been having problems with increased battery consumption which according to my the battery use monitor is caused by the browser app. The strange thing is that it can occur even when the browser isn't active. I have investigated the problem and discovered that it is connected to 'Reddit is fun'. I can reproduce it by first starting the browser app, starting RIF, opening a link in RIF which opens in a new browser window, then closing the link with the Back key. This causes the browser app running in the background to use a steady 10 - 15% of the CPU which really sucks the juice out of my battery. It only occurs when the browser is already running in the background prior to opening the link in RIF. I am running the custom donut rom from Amon-RA and this could well be the source of the bug. If you should have a chance to try it out on another donut build, I would be most grateful to hear the result."""

Need ability to send PMs not just replying

Currently the six options on the menu include "sort by." I could be mistaken, but I can't imagine anyone re-sorting more often than they check their inbox. It seems a good design choice to move the sort button to the "more" menu, so that the more commonly used inbox can be a top-level choice.

A number of users have been reporting force closes when using CyanogenMod and apps2sd, usually when returning to the Activity from another activity (viewing a link in browser then returning)

Unfortunately I don't use cyanogen or apps2sd and can't reproduce the bug. Would anyone mind checking this out please? :)

I wonder if running TaskKiller to free up some memory would help?

EDIT: Ok, I'm going to try switchrom.sh (http://forum.xda-developers.com/showpost.php?p=4209412) and debug it myself...

EDIT2: Got cyanogen installed, with its automatic apps2sd stuff. I have now indeed encountered force closes that I didn't encounter with stock rom. They mostly happen when rotating the screen. Happened again when rotating screen with login dialog onscreen. Also I get a weird bug where it doesn't load the threads list correctly the first time, and I have to refresh to get anything to show up.

There's a problem with redditmail where it prompts me to read "new" mail that I've already read.

Reddit added a new sort-by option called "best"
For this app, would need to modify menu xmls, and corresponding code.

I think the scraper is broken and isn't always loading people's subreddits correctly

Warrants a double check

It's handy not having all messages suddenly marked as read on the desktop, that way you know what you have and have not reviewed yet. If the setting is not selected then reddit is fun will not mark messages that you check as read, resulting in multiple notifications for the same message until you mark them as read in a browser.

Sometimes I'll be browsing in reddit, I'll click on a link, go to comments, and comments from my previous session will load. I'm trying to recreate it, I believe it has to do with sleeping the phone while reading comments.

Hardware: Motorola Droid

I downloaded the source code, fixing bugs are a great way of exploring the code repository :)

"This happens the first time I load a comments page after switching subreddits, forcing me to go back and reload the page manually; simply refreshing doesn't seem to help."

Clicking OP doesn't bring up menu when there is selftext. This is caused by broken Android WebView behavior. Maybe I should use ugly TextView, and have it look better when markdown is eventually better implemented?

Need the ability to hide an article, by pressing a button and/or swiping the article in the article list. Should integrate with the reddit 'hide' feature

Additionally, it would be nice to have the option to automatically hide read articles and show hidden posts.

Something that has been missing all along is the registration function. This should be straightforward. Registration uses a CAPTCHA but the code for CAPTCHAs already exists in SubmitLinkActivity.

Need to show user history which can consist of both threads and comments.

Search is not yet implemented.

I want to be able to batch download and cache the JSON for threads lists and comments lists. And ability to optionally sync an offline JSON with the current updated one.

Things to consider:

• You can grab at most 200 comments in one go. To load more comments you need to branch off of the "more" info in the JSON file.
• The user needs to have an estimate of how much space the downloaded content will take, both for SD card capacity checking and for pay-per-bandwidth cell plans.
• Probably need to use specialized Activity to view cached stuff. Probably shouldn't be allowed to reply to cached content (since you might be saying something redundant that someone else has said). Voting should possibly be allowed.

getting "invalid subreddit" for some subreddits like /r/gaming and /r/funny, excluding frontpage and bestof.

I am pretty sure it's an API change with maybe the JSON object under "oembed" key.

Along with this there does seem to be some new cool info for threads which can be incorporated in the future.

I've implemented the ability to report comments into my fork of this app but someone still needs to implement the ability to report an entire thread.

because mVoteTargetThingInfo loses its reference...

It's possible to have an intent-filter for HTTP URIs based on domain. All that is needed would be some pattern matching to direct the parsed URL to the correct Activity. (RedditIsFun for link to subreddit, RedditCommentsListActivity for link to thread, MoreChildrenActivity for link to a comment)

Markdown needs to be at least partially implemented. For hyperlinks, bold, italics at least. (Not quite sure how hyperlinks would be done, since if they don't appear in the string, we might need to change behavior away from Android built-in "autoLink" feature.)

I'm not sure if using SpannableStringBuilder on every comment would be too slow. From comments on the Internet it looks like using WebViews for comments would definitely be too slow. So leave as TextViews for sure.

EDIT: Yes, markdown is SLOW for long comments (during JSON parse phase)
EDIT2: It's now acceptable speed using dk.brics.automaton

This should be an easy addition. Ability to disable rotation via a preference setting.

http://www.anddev.org/viewtopic.php?p=23174#23174
setRequestedOrientation(1); // sets orientation to portrait

List of other settings:
http://developer.android.com/reference/android/R.attr.html#screenOrientation

Ability to create/access saved posts

Can we get thumbnails for posts in the post list?

If you go into a subreddit, for example "android" if you type "an droid", the app crashes completely. App should gracefully warn the user, or better would be to simply strip the whitespace.

Oops I broke show more comments. Need to implement multi-file cache for CommentsListActivity since you can have a stack of them.

idea: name them comments00.dat, comments01.dat, etc.
and when you load a CommentsListActivity it always loads the highest one. then pressing Back button deletes the highest one.

problem: how do you drop out of the entire stack quickly? using application launcher works?
problem: user enters reddit is fun from a different entrypoint. need to clear entire cache then. what happens to activity stack then?

The first check in ThreadsListAdapter.getView() will be true and skip the button setup if the thread count is 25 or less.

Can be reproduced by going to the /r/blog subreddit.

I have an issue with the app. Whenever I visit a link then press the back button from the browser, I end up on my home screen. I used Taskiller to verify that the process is no longer running after I open the browser, but before I hit the back button.

This started happening a week or two ago. I'm not sure if it happened after an upgrade of the app.

I'm running Cyanogenmod 4.2.9.1
I have very few other processes running, and 28MB of RAM free before running Reddit is Fun.
I have a G1.

I did some more testing. After a reboot the app worked fine. But then the problem came back again later in the day. I'm running Reddit is Fun (RIF), and then I open Taskiller from the persistent notification. I only ran Taskiller, and via the notification, because I wanted to launch another processes without having to go back to the home screen, or click anything in RIF. Just so I could see what happened in this case. RIF is crashing as soon as another activity begins. Apparently from an "Activity pause timeout". I took a look at the Android log and this is what I found.

01-07 14:15:56.590 W/ActivityManager( 141): startActivity called from non-Activity context; forcing Intent.FLAG_ACTIVITY_NEW_TASK for: Intent { cmp=com.tni.TasKiller/.TasKiller }
01-07 14:15:57.140 W/ActivityManager( 141): Activity pause timeout for HistoryRecord{43d26f20 com.andrewshu.android.reddit/.RedditIsFun}
01-07 14:15:57.400 W/Resources( 2097): Converting to string: TypedValue{t=0x12/d=0x0 a=2 r=0x7f060004}
01-07 14:15:57.630 D/dalvikvm( 2097): GC freed 8826 objects / 489992 bytes in 153ms
01-07 14:15:57.740 I/ActivityManager( 141): Process com.andrewshu.android.reddit (pid 2188) has died.
01-07 14:15:57.740 I/ActivityManager( 141): Low Memory: No more background processes.
01-07 14:15:57.740 I/WindowManager( 141): WIN DEATH: Window{43c2dd80 com.andrewshu.android.reddit/com.andrewshu.android.reddit.RedditIsFun paused=false}
01-07 14:15:58.340 W/InputManagerService( 141): Got RemoteException sending setActive(false) notification to pid 2188 uid 10053
01-07 14:15:58.420 I/ActivityManager( 141): Displayed activity com.tni.TasKiller/.TasKiller: 1281 ms (total 1281 ms)

http://www.reddit.com/r/Android/comments/bmxxr/a_few_reddit_is_fun_thoughts/

1. I have Reddit set to show 100 entries on the home page instead of 25. Your app correctly downloads all 100 entries, but the progress meter only goes to 25. It would be ideal if it would show the right progress.

Hi,

Love the app, but it needs some caching or something. Returning from a link or comments reloads the first page of results instead of the page I was on. Also rotating the screen reloads the first page when I was viewing one further in.

Keep up the good work!

wtf? haha

When I go to the Inbox, go to reply to a private message, and turn my Nexus One on its side, it Force Closes.

It would be nice to be able to edit and delete posts and comments from within the app.