talcohen / cshwebpacket Goto Github PK

I guess they used to be on paper packet. I think it makes sense that they would be since they're mentioned separately in the constitution.

I think it would be nice to have a percentage visualized without taking "freshman signatures" into account.

Right now, the grid page does a separate query for each grid, making it very slow. You can change this to be one complex query and then format the results in memory, which will speed up the entire page by a ton.

The footer gets ugly AF when you resize it. The search bar and the It's All About Tal button gets pushed down to another line and it covers your name.

http://imgur.com/a/rXQWy

Freshmen have had an issue where they take a really long time to fill out the written portion of the packet, and then as they hit submit they must sign in again and their progress is lost. I don't know if this is a fixable issue, but someone complained about it so I thought it was worth noting.

So the idea was once brought up to add Photos to Packet in order to help put a face to a name.
There is the issue that incoming freshman don't have access to profiles yet to add a photo, however everyone else does. That would at least allow people who are on packet to help associate names with faces (or at least profile pictures).
Example (obviously rushed job, it would look a lot better than this):

The page /freshmen shows how many signatures each of the freshmen have. This is super useful, however when looking through which freshmen have the most signatures, it'd be useful to see which of those packets I have signed. It'd be cool if you could add some sort of differentiator on that page to show which I've signed.

This is a sev 1 ticket and must be address quickly!!

I would love to see the names of the people that I have and have not signed for a given year. As soon as a person passes their 2 week mark, I can no longer see if I signed someone or not. I do not like having to keep a copy for my own record of who I have and have not signed.

This should contain its own audit logging, which tracks the time, date, signer, authenticated user, IP and signee of all signatures. If a user is suspected of forging a signature, this log should be able to semi-reliably determine whether or not someone actually signed a packet.

It would be nice to see how much time a freshmen has left to complete the packet. This is not an issue normally during the first group of freshmen, but for freshmen who join later or get extensions, it does matter.

It would be cool to have a graph that shows signatures earned per day. Potentially a week long breakdown that shows when the signatures were earned during the two week period and a daily view that shows the time of day the signatures were earned. This would be useful to see what days the freshmen were on floor and how many of their signatures were last minute.

Currently, freshmen can sign their own packets. It looks like that may be able to be fixed in /app/controllers/signatures_controller.rb. The linked line checks if the user has selected a freshman's packet, and is signed in as a freshman, but not whether or not the freshman signed in is selecting their own packet. This can add artificial signatures to their packet. You can see in this screenshot that I've been able to sign my own packet.

(Quest done, Liam)

If an on floor freshman goes to the list to sign the packet of an off floor, off floor names do not appear. However, if an on-floor freshman goes directly to the URL of an off-floor, they ARE able to sign.