takufunkai / pe Goto Github PK

There are no different colours demarcating the different components involved (both logic and model are grey).

Also, the details are not high-level enough, making the diagram wordy and confusing.

Problem: medical details for S1234567L (sample data) has "cm" for weight.

Here, i/NRIC is indicated for add and view, but edit INDEX is not indicated. Inconsistent especially between view and edit, since both i/NRIC and INDEX should serve the same purpose of identifying the contact to view/edit.

This makes it confusing for the user, especially since one would expect to edit the same way you view, or add a contact. Since this is not the case, it is better to be explicit with the indexing method.

Problem: Some commands require to reference contacts by their NRIC (unique identifier), other commands require reference by index. There does not seem to be a standard/rationale behind it.

Adding medical information requires i/NRIC

Whereas we won't be able to edit the contact's medical information by NRIC, and only by index.

Problem: Deleting the contact in view mode brings us to a blank page instead of the patient dashboard.

To reproduce:

1. View a patient: view i/S1234567L
2. Delete the patient delete 1

Problem: There is a typo when typing in an invalid password.

To reproduce: Type non-matching, but otherwise valid passwords.

Under patient specific commands, view i/NRIC is listed with i/NRIC, but for contact specific commands, it is listed as view t/contact without the i/NRIC identifier.

This can be confusing, since view t/contact does not work without the NRIC identifier either, but is omitted from the contact specific view command (and not ommited from the patient specific view command).

Problem: when running find, it does not look through personal details of the contact (although this is done for prescriptions, medical information etc.)

To reproduce:

1. Find a person's handphone number find 93210283
2. There won't be any result.

Problem: While it was explained that there is currently no way to reset password, it should have been taken into account that medical records of patients are extremely sensitive and being able to reset password is part of regular security measures.

The current way to "reset" the password is by wiping the data completely.

Problem: Currently, NRIC are parsed case sensitive. However, since NRICs should only have capitals, the user might have a better experience if they do not have to capitalize their alphabets.

For example, allow: view i/s1234567l

Problem: When trying to edit information of the patient in summary view mode, we are brought back to the main view page.

To reproduce:

1. View a patient: view i/S1234569L
2. Edit address: edit 1 a/Random address
3. You should be brought back to main page.

Since the fields we can add and edit are not always the same (can't edit NRIC, some fields are compulsory in add but not edit), it would be good to spell it out clearly for the users what edit parameters there are.

Here it should be view t/medical | View Medical Information instead of Contact information.