takahikokawasaki / twitteroauthview Goto Github PK

Hello TakahikoKawasaki,

First of all thank you for the project.

I have integrated in my project TwitterOAuthView and TwitterOAuthActivity example. I have an activity from a button pricipal and call startActivityForResult.He TwitterOAuthActivity with some modification done to me and I return the end result after activity to login with Twitter.En WebView principle works correctly but when it starts and the screen Twitter login if you press the back button and then from the main actvidad press the back button login with Twitter WebView starts again but this time nothing appears on the screen and not have it appear as content or Webview resetee.Estoy are trying to treat it with the method onBackPressed () from TwitterOAuthActivity but not if TwitterOAuthView there or where I have to make changes as I see it is in the method OnPreExecute () of TwitterOAuthTask and does not reach the doInBackground ().

If you could give me some idea or help I would greatly appreciate it.

Thank you very much,

Jmdr

When TwitterOAuthView has loaded Twitter's application authorization form, and the user navigates away from the fragment or activity containing the view, the underlying TwitterOAuthTask (which extends AsyncTask) remains blocked, as a result of the call to Object.wait() in its waitForAuthorization() method. However, this means that, on Android 4.x where only one AsyncTask can be executed at a time, any other AsyncTask belonging to the application will never start until TwitterOAuthTask receives a proper notification via Object.notify(), which will never be called.

As a side effect, on Android 4.x it's also impossible to load TwitterOAuthView two times in a row if the first time the user has navigated away from the fragment or activity containing the view, because the AsyncTask that loads Twitter's authorization page cannot be executed until the previous blocked AsyncTask receive an Object.notify() call.

Your LocalWebview class unconditionally calls handler.proceed() in onReceivedSslError, which is insecure. This effectively disables ssl entirely.

Hi, I've found your solution for login to twitter on stackoverflow.
Here you say that if I pass "true" as DUMMY_CALLBACK_URL "TwitterOAuthView does not access the callback URL" but it does. The only difference with the example in your repo is that I'm starting the TwitterOAuthActivity from a fragment.

When using TwitterOAuthView in an application capable of following the device orientation, the view's content disappears upon device rotations, leaving the view itself blank.

On second thought, this is probably related to issue #4.

When the Cancel button on Twitter's authorization page is pressed, the listener should be notified via a proper method, so that e.g. the view could be closed instead of showing the next page in Twitter's web flow.