Giter Club home page Giter Club logo

react-address-lookup's People

Contributors

dependabot[bot] avatar mparry-warburtons avatar taelkir avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

react-address-lookup's Issues

Doesn't seem to work with React 17

When I went to install this with a Next.js 11 test site I got the following NPM message:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.6" from [email protected]
npm ERR! node_modules/react-address-lookup
npm ERR! react-address-lookup@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Cannot find module 'react-address-lookup' or its corresponding type declarations. ts(2307)

Having some trouble getting this module to actually import, at all. Both in typescript and also in the compiler.

Screenshot 2022-04-26 at 13 55 47

We see a typescript error saying the module cannot be found, and also...

Screenshot 2022-04-26 at 13 56 30

Remix also cannot find the module when it tries to build the page in which I am attempting to import the module.

Screenshot 2022-04-26 at 13 57 41

What I did notice is in the installed version, in node_modules, the index.js is not there.

Debug info: Remix 1.4.0 (React 17), macOS 12, Node 16.14.2

TypeScript

We could do with adding type definitions for TypeScript users, or just migrating to TypeScript completely. Been >6 months since I last worked with TS, so would need to refresh my memory a little on if you can do the former without the latter.

Upgrade to React 18

Could probably do with waiting until Storybook supports React 18 before moving this one along.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.