t145 / metal-chests Goto Github PK

Expected Behavior

Close Sorting Chests, send items to it via hopper/filter, expect its lid to stay closed

Actual Behavior

Lid stays up until reloaded/replaced

Steps to Reproduce (including precondition)

Setup a filter using the sorting system.
Send item to the system.
Open chest once.
Lid remains open forever

Your Environment

• OS: Windows 10
• Full Forge version: 1.12.2-14.23.4.2747
• Mod version: v3.0.5.ge3381ce

"Soo, you will add this feature in one of the next versions? :D
(pls with anvil re-name support^^)"

T145 said = "@TheSnowyChickens Perhaps; I'd say anvil renaming should be a separate issue."

Expected Behavior

Re-name feature.

Actual Behavior

No re-name feature.

Steps to Reproduce (including precondition)

1. Place a chest.
2. look inside.

Screenshot of this Problem

Your Environment

• OS: Win10
• Full Forge version: 1.12.2 - 14.23.4.2747
• Mod version: Release v3.1.6

What we are thinking of was being able to set materials, size per material, and what upgrades can apply to each material.
For our purposes we can have wood >copper >gold>diamond>obsidian as a path as well as wood >iron>steel>obsidian for people who have gotten that far in our tech progression.
It will also help us establish that bronze and iron are equivalent mechanically save for rarity by being able to add bronze chests and set them to the same size as iron chests.

Crafting Chest

Hey i like Metalchest but i get an idea for you to make it more usefull than Ironchest mod

Could you add crafting table with metal upgrade ?

Like a copper version wich keep inventory, get an internal copper storage chest and upgradable for more internal storage ?

Error Details

Replication steps:

Place down a vanilla double chest. Fill all six rows to the brim with cobblestone. Apply a wood-to-iron upgrade to one of the two sides of the double chest. Open both chests and look inside.

Expected result:

Wooden single chest contains three rows of cobblestone. Iron single chest contains three rows of cobblestone and three empty rows.

Actual result:

Wooden single chest contains three rows of cobblestone. Iron single chest contains six rows of cobblestone and no empty rows.

The three extra rows of cobblestone are real, persist through relogging, and can be taken out and used.

So is this a dupe bug? Nope. Upon taking something from the wooden chest and then looking into the iron chest, you'll see that the corresponding slot there is now also empty. This also works vice versa (taking from the iron chest results in empty slots in the wood chest). In other words, the upgrade does not properly unlink the double chest.

Environment

• OS: Windows 10, latest patch level
• Full Forge version: Minecraft 1.12.2 on Forge 14.23.5.2768
• Mod version: v3.9.0

No other mods are required to reproduce.

Expected Behavior

Server is starting.

Actual Behavior

Server crash on startup (without Thaumcraft)
https://gist.github.com/KorDum/8ddd10721b0b0dc4534e468f6708ee10

Your Environment

• OS: SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64
• Full Forge version: 1.12.2-14.23.4.2750
• Mod version: 2.5.3.g03c118f

Crystal Chests for some odd reason do not retain their inventory and instead re-add items to the players inventory if they open the chest again, however if a player doesn't re-open the GUI and starts messing around with items in their inventory they get permanently deleted and you're stuck with a chest that refuses to hold anything

Forge : 14.23.4.2739
Metal Chests : 1.2.2

Forge version forge-1.12.2-14.23.4.2757

Game crashes on load with metalchest added. Same thing happens with the two neweset versions, I haven't tested an older version.

It's strange, that the last version of your mod worked for a while now and it suddenly changed. It seems to be a problem with thaumcraft, but reverting two an older version oc TC doesn't change anything. forge 66 doesn't work either, forge 68 is incompatible with immersive engineering and thaumcraft

Crashreport

Maybe I'm dumb and I made a mistake, but there seems to be a problem

I got one thought... You dont have crystal chest, and this is actually your disadvantage.
Most usefull part of crystal chests is that you can see what's inside.
What if you make your own crystal chest, and it will show what's inside. But not everything, only specific slot. For example you add extra slot, player can place "ghost" item for a chest to show.
Metal ingot for metals chest, wooden log for wood chest, etc. I think it would be quite cool.

Here's screenshot of metal chest in NEI. NEI seems to not finding metal chests.

Error Details

https://paste.dimdev.org/rolunidiwa.mccrash

As soon as you click the metalchest pick in the creative menu it crashes you straight to the desktop

https://paste.dimdev.org/rolunidiwa.mccrash

Screenshots

Environment

• OS:
• Full Forge version: 1.12.2 forge 2772
• Mod version:
  V3.8.1

Expected Behavior

Hoppers push items into and from Minecarts with Metal Chest

Actual Behavior

Hoppers don't interact with Minecarts with Metal Chests

Steps to Reproduce (including precondition)

1. Place a rail on a hopper.
2. Place a Minecart with Metal Chest on the rail
3. Put items in the Minecart with Metal Chest

Your Environment

• OS: Windows 10
• Full Forge version: 14.23.4.2750, Minecraft 1.12.2
• Mod version: 2.5.7

Error Details

https://gist.github.com/TacticalUniverse/93bf773570eb250c63b4bb9c22585c57

Screenshots

Environment

• OS: Windows 10
• Full Forge version: 1.12.2(modded) forge-14.23.5.2796
• Mod version: 3.0.9

Some easy stuff:

• wrong TOP name info
• Item z-fighting (I hope this is the right feature/thing/name :D )

Steps to Reproduce (including precondition)

Look at a Minecart and hold the Item in the hand an move the cam.

Screenshot of this Problem

The 3 red arrows shows the 3 points of z-fighting

Your Environment

• OS: Win10
• Full Forge version: 1.12.2 - 14.23.4.2749
• Mod version: MetalChests-v2.3.9.gb92ee2f
• Theoneprobe-1.12-1.4.23

(Yes, Optifine is installed, but I have the same fighting bug with the tinkers axe without Opti)

Actual Behavior

Updating from v1.2.2 to any newer version makes chest invisible until rightclicked and deletes all items.

Steps to Reproduce (including precondition)

1. Have some Metal Chests with items on v1.2.2
2. Update to v2.0.0 or v2.3.9

Your Environment

• OS: Windows 10
• Full Forge version: 14.23.4.2749
• Mod version: v2.3.9

Oh fear we the touch of the sea, bringer of rust and corrosion
Please add these dread and terrible chests to the mod that our undersea bases experience that fear!

I'm ignoring your default form. I hope it is okay. You added quark support but the searchbar is too big in all your chests.

The crash

[04:31:09] [Server thread/ERROR] [net.minecraft.server.MinecraftServer]: Encountered an unexpected exception
net.minecraft.util.ReportedException: Exception while updating neighbours
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:773) ~[MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.updateTimeLightAndEntities(DedicatedServer.java:397) ~[nz.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668) ~[MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_181]
Caused by: java.lang.NullPointerException
	at net.minecraft.block.BlockDoor.neighborChanged(BlockDoor.java:228) ~[aqa.class:?]
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.neighborChanged(BlockStateContainer.java:481) ~[awu$a.class:?]
	at net.minecraft.world.World.neighborChanged(World.java:550) ~[amu.class:?]
	at net.minecraft.world.World.notifyNeighborsOfStateChange(World.java:491) ~[amu.class:?]
	at T145.metalchests.tiles.TileMetalChest.update(TileMetalChest.java:213) ~[TileMetalChest.class:?]
	at net.minecraft.world.World.redirect$tileEntityUpdate$zzi000(World.java:4128) ~[amu.class:?]
	at net.minecraft.world.World.updateEntities(World.java:1832) ~[amu.class:?]
	at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:613) ~[oo.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:767) ~[MinecraftServer.class:?]
	... 4 more

Steps to Reproduce (including precondition)

Place a metal chest in front of an iron door

Error Details

1. of your questions: Can't open the minecart with chest.
2. of your questions: I should can open it ?
3. of your questions: I can't
4. of your questions: I have only this: https://paste.dimdev.org/jupilakori.mccrash

Screenshots

(I right click the minecart = the info in the top right corner)
(Yes, these minecarts are placed/spawned with 3.7.0, these are not 3.1.6 carts)

Environment

• OS: Win10 (1803) 64bit
• Full Forge version: 1.12.2 - 14.23.4.2765
• Mod version: 3.7.0

PS: If you need more info, u need to wait ~7h, because I go to sleep now.

As base metals adds a plethora of metals, this might be a good basis for adding more modded materials.

https://minecraft.curseforge.com/projects/base-metals

Thermal Foundation might be a good idea too, since it covers a lot of the same ground.

https://minecraft.curseforge.com/projects/thermal-foundation?gameCategorySlug=mc-mods&projectID=222880

And as for Embers, it has received a new spark of life, and has some standard metals you could hook into.

https://minecraft.curseforge.com/projects/embers-rekindleated?gameCategorySlug=mc-mods&projectID=300777

Crashlog

Your Environment

• OS: Windows 10
• Full Forge version: 1.12.2, 14.23.4.2756
• Mod version: 2.9.5

Error Details

• Crashes upon trying to load up.
  I updated to the new version this morning, the old was working perfectly. I try to load it up and it crashes every time i tried, everything is up to date and everything worked prior to me updating this mod.

crash-2018-10-02_07.11.38-client.txt

~~ Environment~~

• OS: windows
• Full Forge version: Minecraft 1.12.2 - Forge 14.23.4.2765
• Mod version: V3.5.6

*** Tried without optifine as well, still crashes the same***

VanillaFix give me some errors. I just put some chests (from MetalChests) into the crystal chest.
This problem only occures with the crystal chest, in other chests I dont get this message.
Log - link is under the screenshots.^^

Expected Behavior

No errors from VanillaFix.

Actual Behavior

Errors from VanillaFix

Steps to Reproduce (including precondition)

Install VanillaFix and your mod and put some chests into the crystal chest.

Screenshot of this Problem

Log: https://paste.dimdev.org/kinuhamebe.mccrash

Your Environment

• OS: Win10 64bit
• Full Forge version: 14.23.4.2747
• Mod version: "v1.2.2.g3d3d54b" (v1.2.2)
• plus more mods (Modlist is in the log)

Expected Behavior

Chests not losing content when upgrading the mod

Actual Behavior

Upgraded from MetalChests-v3.0.5.ge3381ce.jar to MetalChests-v3.1.6.g7177eac.jar

Obsidian chests lost all content and changed rotation, they are backwards now.

Steps to Reproduce (including precondition)

Upgrade from MetalChests-v3.0.5.ge3381ce.jar to MetalChests-v3.1.6.g7177eac.jar

Your Environment

• OS: WIN10
• Full Forge version: Forge Mod Loader version 14.23.4.2749 for Minecraft 1.12.2
• Mod version: MetalChests-v3.1.6.g7177eac.jar

Expected Behavior

Leave world, come back in. Expect filters/things to work

Actual Behavior

Logic doesn't update. The entire setup needs to be reset/replaced.

Steps to Reproduce (including precondition)

Make a filter. Test it. Reload world. Done.

Screenshot of this Problem

https://youtu.be/x088Bnk5QiQ

Expected Behavior

Buttons should appear beside MetalChests inventory.

Actual Behavior

No buttons appear.

Steps to Reproduce (including precondition)

Use Quark r1.4-122 with MetalChests v1.2.2.g3d3d54b.

Screenshot of this Problem

N/A

Your Environment

• OS: Windows 10 Pro x64
• Minecraft version: 1.12.2
• MetalChests version: v1.2.2.g3d3d54b
• Forge Version: 1.12.2-14.23.2.2624

Expected Behavior

Minecarts with Metal Chests drop their content when broken

Actual Behavior

Minecarts with Metal Chests don't drop their content when broken and the items are deleted.

Steps to Reproduce (including precondition)

1. Place a Minecart with Metal Chest on a rail.
2. Put some items in it.
3. Break the Minecart with Metal Chest.

Your Environment

OS: Windows 10
Full Forge version: 14.23.4.2750, Minecraft 1.12.2
Mod version: 2.5.7

Error Details

Hi,

I'm using Metal Chests and Charset Chests in a mod pack but noticed there isn't support between the two when using the chest upgrade items.

I'd like to be able to use the upgrades on the Charset chests without having to craft a new Metal Chest and then moving the items over.

Right clicking an upgrade on these chests doesn't result in a change.

Many thanks!

Environment

• OS: Windows 10 (Client Side) & Debian 4.9.51-1 (Multiplayer Server)
• Full Forge version: MC 1.12.2, Forge 14.23.4.2756
• Mod version: MetalChests-v3.1.6.g7177eac.jar

I just get tired of seeing them.

https://pastebin.com/qe3WMHN7

Error Details

https://gist.github.com/TacticalUniverse/131cb9095fbe6dce1a8d70803c06a4a1

Screenshots

Environment

• OS: Windows 10
• Full Forge version: 1.12.2(modded) forge-14.23.5.2796
• Mod version: 3.9.0

As of 3.9.0, chests are missing the generic 'chest' ore dictionary registration.
They do have their specific material variation registered, just missing the generic one also found in vanilla.

Feature

Be able to add metal chests to a minecart by right-clicking on it if Quark is installed, as it's not a vanilla feature.

-- Expected behavior
If I have materials for chests ( copper, silver, etc ) I should also have the recipes for those chests.

-- Actual behavior
Even though properly oredicted materials exist, I only have vanilla material recipes available.

-- Detailed logs of the issue -->
I'm currently using Embers Rekindled for these materials, but I would expect that it just came from the oredict, so that any mod that added a proper material would work.

I also have thaumcraft installed and don't seem to have any recipes for the hungry chests. Not sure how those are supposed to work though, might not be a regular crafting recipe.

Environment

• OS: Win10
• Full Forge version: 1.12.2 14.23.5.2768
• Mod version: v3.8.1.gfd0d85a

Just always would have liked metal chests in boats and minecarts. I pulled one off, and told me on curseforge to suggest it here. Just thought why keep the chest stationery. Boats seemed better way, shulkers were okay but end game. It might req new boats, but we lack them as well in mods.

Error Details

I've upgraded a double wooden chest to iron chest, it wast full, and after that upper half of it's content was at once and in upgraded chest and in 2nd wooden chest.

Environment

• Full Forge version: 14.23.4.2747
• Mod version: v3.1.6.g7177eac

When I load a world with crystal chests, they are invisible until I hover over them with the player looking thingy.

Expected Behavior

Crystal chests should always be visible.

Actual Behavior

Note that the first crystal chests I'd already looked at before taking screenshot. Both existed at world load though.

Steps to Reproduce (including precondition)

1. Place crystal chest.
2. Close world.
3. Re-open world.

Screenshot of this Problem

Your Environment

• OS: Windows 8.1
• Full Forge version: 1.12.2-14.23.4.2727
• Mod version: 1.2.2

Expected Behavior

Should display "Iron Chest", "Gold Chest", etc.

Actual Behavior

Displays tile.metalchests:metal_chest no matter which chest is used.

Steps to Reproduce (including precondition)

Use HoloInventory 1.12.2-2.0.2.148 with MetalChests v1.2.2.g3d3d54b.

Screenshot of this Problem

https://i.imgur.com/4Rudr5v.png

Your Environment

• OS: Windows 10 Pro x64
• Minecraft version: 1.12.2
• MetalChests version: v1.2.2.g3d3d54b
• Forge version: 1.12.2-14.23.2.2624

1. Move config file from T145 folder into main Config folder, so it's easyer to find. Or atleast name this folder "Metal chests"
   2.0) Hide chest variant if there is no supported metal (Copper and Silver if there is no mods with these metals)
   or
   2.1) Add option to disable and hide any chest variant via config, including upgrade for this variant

Overall, i think this mod is better then Iron Chests, because there is no Shulker, and no "joke" dirt chest

P.S. Don't mind 2.0, because i see you already aware of this problem

The easiest way to describe it. :=)
Under my post you can see 1 comment from the Carry On developer.

Tschipp/CarryOn#124 (comment)

Expected Behavior

Correct side from the lock, after end of carrying.

Actual Behavior

It noted the lock side and dont rotate to the new placed side.

Steps to Reproduce (including precondition)

Place the chest -> use carry on -> place the chest on a other block.

Your Environment

• OS: Win10 64bit
• Full Forge version: 1.12.2 - 14.23.4.2747
• Mod version: v2.0.0

Also "Chest transporter" dont support your mod and I always open a issue for the support on their Github.

When I apply a new upgrade to a chest, say the copper to iron upgrade, if I subsequently open the chest, it does not close when I exit the inventory.

Expected Behavior

Chest should always close if nobody's in it.

Actual Behavior

Steps to Reproduce (including precondition)

1. Apply upgrade (such as iron to silver upgrade) to chest.
2. Open chest.
3. Use esc to exit the chests inventory gui.
4. Observe failure to re-close.

Screenshot of this Problem

Your Environment

• OS: Win 8.1
• Full Forge version: 1.12.2-14.23.4.2727
• Mod version: 1.2.2

Actual Behavior

I updated mod from v3.0.2.g1652b57 to 3.1.6.g7177eac.
In the log errors are written after server startup:
https://gist.github.com/KorDum/70dbf289964faabe1658a8d5076aaa10

Your Environment

• OS: SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64
• Full Forge version: 1.12.2-14.23.4.2750
• Mod version: 3.1.6.g7177eac

Error Details

When I try to apply an upgrade of any level to a basic Hungry Chest, the Hungry chest is changed to that level of regular chest. For example: if I attempt to apply a Wood to Obsidian Hungry Chest upgrade to a basic Hungry Chest, it changes the Hungry Chest into an Obsidian Chest.

I also tested starting with metal Hungry Chests, and the upgrades seem to work as expected for those, so it is only when upgrading the basic Thaumcraft Hungry Chest to a metal Hungry Chest.

Screenshots

Before - With me holding the upgrade I'm trying to apply

After

Environment

• OS: Ubuntu 14.04
• Full Forge version: 14.23.5.2768
• Mod version: 3.7.0 (also Thaumcraft BETA26)

Error Details

I wanted to open the creative tab, but it crashed.

Details:
-- Expected behavior -> I can open the creative TAB
-- Actual behavior -> Can't open = crash
-- Crash report ->
crash-2018-10-14_16.56.38-client.txt

Screenshots

Environment

• OS: Win10 64bit
• Full Forge version: 14.23.5.2770
• Mod version: v3.7.0.g0616017

Seems to be that when using an upgrade item on a chest or cart going up to the crystal tier, the items do not render right away. The inventory needs to be updated by opening the inventory, and then everything works perfectly. Fixing this for the chest should also fix it for the cart naturally, as the cart maintains a copy of TileMetalChest.

Comparison
https://imgur.com/a/JfQOvjG (warning: image for ants ahead)

https://drive.google.com/open?id=1GMzDVkhK66Zc1vaaSSycoYVOp2X3p3ME

I edited it for myself but figured I'd drop this off here. It doesn't look like you can actually put anything into the chests without the black void being there!

Just a simple Request ;p

Could you add an Oredict for chest (ore:chest and ore:chestMeTal) please ?

https://imgur.com/a/yFyJjxm

-- Inventory tweaks buttons shouldn't overlap chest slots
-- The buttons clip/cover slots on the far right, similarly to chests from Iron Chests
-- Maybe each chest should say "Iron Chest" or "Gold Chest" at the top similar to vanilla chests to leave room for the buttons.

• OS: Fedora 29
• Full Forge version: 14.23.5.2808
• Mod version: 4.0.1

Currently, this mod provides only single blockspace chests. I think it would be cool if it provided the ability to put two of the same type of chest next to each other, and have them behave like the vanilla double chests, having both inventories accessible via the gui, or something similar to the InventoryLargeChest class.

Expected Behavior

Server is starting.

Actual Behavior

Server crash on startup (Client starting was fine)
https://gist.github.com/KorDum/11d916ad508854b1eb3ef0063eb89bc2

Your Environment

• OS: SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64
• Full Forge version: 1.12.2-14.23.4.2739
• Mod version: 2.2.9.g75160ec