t-vk / memory-hacking-class Goto Github PK

So I'm trying to use this module, (specifically the GCC branch) and whenever I try to use the GetModuleBase function, it always returns -1. I have tried it with the example2 program, and it still has the same issue. If this is just me being dumb, please let me know, and if you don't feel like fixing it, do you have any other modules that you could recommend to use instead of this one?

Hi, I wanted to use your library for my purposes and I approached some issues. I figured out how to manage some of them. Mostly, I had to change some types, but the logic hasn't changed. However, when I finally made my code buildable and wanted to test it, I approached another issue which I couldn't manage on my own. I'm receiving system error 998 when trying to read from the memory.

Here's my code.

int main() {
    SetConsoleTitle("Memory Class Test");
    std::string TARGET_PROCESS_NAME = "test_app.exe";
    
    HANDLE processHandle;
    int64_t baseAddress;
    
    Memory Memory;
    Memory.GetDebugPrivileges();
    int processId = Memory.GetProcessId(const_cast<char*>(TARGET_PROCESS_NAME.c_str()));
    processHandle = OpenProcess(PROCESS_ALL_ACCESS, false, processId);
    
    baseAddress = Memory.GetModuleBase(processHandle, TARGET_PROCESS_NAME);
    std::cout << "Base address for module \"" << TARGET_PROCESS_NAME << "\" is " << baseAddress << " (in dec)..."<< std::endl;

    std::cout << Memory.ReadInt(processHandle, baseAddress + 0x7FF648CF3000) << std::endl;
    
    return 0;
}

And here's yours with as few changes as possible. In this case, the only change I had to make was changing the dwBase variable type to int64_t. What caused a change in ReadInt function

int64_t Memory::GetModuleBase(HANDLE processHandle, string &sModuleName) 
{ 
    HMODULE *hModules = NULL; 
    char szBuf[50]; 
    DWORD cModules; 
    int64_t dwBase = -1;

    EnumProcessModules(processHandle, hModules, 0, &cModules); 
    hModules = new HMODULE[cModules/sizeof(HMODULE)]; 
    
    if(EnumProcessModules(processHandle, hModules, cModules/sizeof(HMODULE), &cModules)) { 
       for(size_t i = 0; i < cModules/sizeof(HMODULE); i++) { 
          if(GetModuleBaseName(processHandle, hModules[i], szBuf, sizeof(szBuf))) { 
             if(sModuleName.compare(szBuf) == 0) { 
                dwBase = reinterpret_cast<int64_t>(hModules[i]); 
                break; 
             } 
          } 
       } 
    } 
    
    delete[] hModules;
    return dwBase; 
}

int Memory::ReadInt(HANDLE processHandle, int64_t address) {
    if (address == -1)
        return -1;
    int buffer = 0;
    SIZE_T NumberOfBytesToRead = sizeof(buffer); //this is equal to 4
    SIZE_T NumberOfBytesActuallyRead;
    BOOL success = ReadProcessMemory(processHandle, (LPCVOID)address, &buffer, NumberOfBytesToRead, &NumberOfBytesActuallyRead);
    if (!success || NumberOfBytesActuallyRead != NumberOfBytesToRead) {
        std::cout << "Memory Error!" << std::endl;
        return -1;
    }
    //if (err || NumberOfBytesActuallyRead != NumberOfBytesToRead) {
	//	DWORD lastError = GetLastError();
	//	if (lastError != 0)
    //        std::cout << lastError << std::endl;
    //    std::cout << "blub" << std::endl;
	//}
    return buffer; 
}

Here you can see that my hard-coded address makes sense:

And here you can see the app's output:

Could you help me, please? I have no idea what am I doing wrong that I have no access to this memory. The test app is an easy app also prepared by me. Almost everything that's there is the initialisation of some variables and an infinite loop.

I seem to be unable to compile this. It could be user error, but could you take a look at it?

C:\Users\arminblack\Desktop\Memory>g++ Program.cpp -static -o Program.exe
In file included from Program.cpp:3:0:
Memory.hpp:2:22: fatal error: stdafx.hpp: No such file or directory
#include "stdafx.hpp"
^
compilation terminated.

Hi, I know this is oudated but i want to use it for something else, but I keep getting errors like this, how can I fix them?
processId is undefined
Process_All_Access is undefined
At line 33 initial value of reference to non-const must be an Ivalue

This isn't an issue with your code but I had a question on its functionality and wasn't sure how else to ask you, I have a bit of an interesting situation.
My base address isn't the games .exe, since its code loaded through a .dll. So basically
I need to connect to my games .exe like normal, but I need to get the value at address game.dll + 0x4394 for example

Can I do this with your code? Can you provide an example of doing this?