Giter Club home page Giter Club logo

Comments (3)

aravindsurya77 avatar aravindsurya77 commented on May 18, 2024 1

Thank you so much @szhsin

from react-menu.

szhsin avatar szhsin commented on May 18, 2024

Hi @aravindsurya77 , thanks for your feedback.

React-Menu was originally design to only handle certain events which are necessary for its functionalities. Because the onClick is not required for MenuItems in a radio group, the event is not fired.

Start from v1.1.0, all DOM events are forwarded to the internal DOM element, so it might be necessary add the onClick event in MenuItem to keep the behaviour consistent.

I will consider the impact of this request on the design and backward-compatibility and release a fix in the next version.

from react-menu.

szhsin avatar szhsin commented on May 18, 2024

This is released in v1.6.0.
The onClick event will fire on menu items inside a MenuRadioGroup, and then bubble up to the Menu component. The onChange event on MenuRadioGroup still fires as normal.

from react-menu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.