Giter Club home page Giter Club logo

acrn-hypervisor's Issues

Fix Pull Request

The pull request projectacrn#52 has too many changes. Ideally, my changes should be one or two commits.

Some logs:-

$ git clone [email protected]:shrmrf/acrn-hypervisor.git
Cloning into 'acrn-hypervisor'...
remote: Counting objects: 1062, done.
remote: Compressing objects: 100% (161/161), done.
remote: Total 1062 (delta 106), reused 221 (delta 85), pack-reused 799
Receiving objects: 100% (1062/1062), 621.79 KiB | 252.00 KiB/s, done.
Resolving deltas: 100% (561/561), done.
Checking connectivity... done.

$ git fetch [email protected]:projectacrn/acrn-hypervisor.git
From github.com:projectacrn/acrn-hypervisor
 * branch            HEAD       -> FETCH_HEAD

$ dos2unix Dockerfile
dos2unix: converting file Dockerfile to Unix format ...
$ vim .travis.yml
$ git diff origin/master > ../my-travis.patch
$ git reset --hard origin/master
HEAD is now at 9600271 Merge branch 'master' into master
$ git apply ../my-travis.patch
../my-travis.patch:10: trailing whitespace.

warning: 1 line adds whitespace errors.
$ git commit -a -s
[master 8c2cf0e] Add .travis.yml and Dockerfile
 2 files changed, 13 insertions(+), 13 deletions(-)
$ git push -f


$ git remote -v
origin  [email protected]:shrmrf/acrn-hypervisor.git (fetch)
origin  [email protected]:shrmrf/acrn-hypervisor.git (push)

Fix Build Environment

In the current CI setup that we proposed (myself and @gvancuts ), we are depending on a generic bundle which we do not have control over. Will it not be better to set up an environment that has a fixed version of gcc etc.? The main advantages would be:-

  • Independence from any single Linux distro
  • Similar environment for all developers and testers
  • Failure conditions can be more easily tested and fixed

Also, then, we can use docker as the only dependency on a Linux machine.

For non-Intel devs (and even Intel devs), it might be simpler to use a glorified docker build (or similar) instead of the usual environment setup following wiki pages etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.