syntax-tree / mdast-util-find-and-replace Goto Github PK

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

[email protected]

Link to runnable example

#4

Steps to reproduce

See new unit test in PR above. The search string is the regular expression /(emph|sis)/ and the replacement text is 'foo'. So the text node with the content 'emphasis' should be replaced with three new text nodes, with the contents 'foo', 'a', and 'foo', respectively.

Expected behavior

The test should pass.

Actual behavior

The test fails because only the first match is replaced, resulting in only two nodes with the contents 'foo' and 'asis', respectively.

Affected runtime and version

[email protected]

Affected package manager and version

[email protected]

Affected OS and version

macOS Ventura 13.5.2

Build and bundle tools

No response

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Problem

That the nodes generated via remark-breaks do not contain position information. This might be something that this underlying library could take care of.

Solution

I'm not 100% sure how much the remark-breaks represents a typical usage of this library, but for the remark-break case this library should be able to automatically infer the position of the break and subsequent text nodes.

Alternatives

Otherwise the replace() callback could contain some context which allows the caller to infer the correct position information.