synss / elogviewer Goto Github PK

When hitting the 'refresh' icon button, Elogviewer takes a lot of time with heavy CPU load to complete the task.

So far, I couldn't determine why exactly this happens. As far as I learned from the code, both startup and refresh use the same logic (method populate), so it should take the same amount of time - right? Startup is pretty quick, almost unnoticeable.

On our last stabilization of ~3.0 on gentoo, one of our developers saw a segfault and applied a patch:

https://bugs.gentoo.org/721522#c2

Can you verify this is correct and add that to the official release so we don't have to keep carrying that patch?

Thanks!

I noticed the following inconsistencies:

• marking an already read entry as unread using Space key with focus on green bullet doesn't restore the bold font of the row
• marking read/unread by clicking on green bullet doesn't work

Edit:
A dark star turns red when clicking it, but when leaving + restarting elogviewer, it is dark again. Probably a related issue?

Elogviewer crashes if removing of a logfile fails, e.g. if the logfile got deleted by some other process or if a user lacks proper permissions.

Suggested fix: pull request #5

The important flag is set without clicking the important column.

1. select a line in the table
2. click in the text window
3. select a line in the table
4. the important flag is set to line selected at step 1

-- originally reported by dol-sen on gentoo bugs.

Hi,

I just bumped the ebuild in ::gentoo repo for 3.0 and I added python3_7 & python3_8 support on it... it runs on 3.8 but emits a warning, this is probably something that should be fixed before 3.9 gets here. Thanks!

$ elogviewer
/usr/lib/python-exec/python3.8/elogviewer:689: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using int is deprecated, and may be removed in a future version of Python.
self.resize(screenSize.width() / 2, screenSize.height() / 2)

I'd like to recommend changing the config directory name from Mathias Laurin to elogviewer. On Linux, it is common practice for the config directory name to reflect the application it belongs to.

Since changing this will invalidate existing configurations for users upgrading elogviewer, I think it would be a good idea to have the ebuild announce the change, e.g.

* Please note that the configuration directory changed from
* '~/.config/Mathias Laurin/' to '~/.config/elogviewer/'. If
* you're upgrading and like to keep your previous settings,
* please rename the directory accordingly.