swup / astro Goto Github PK

Describe the problem

• From this comment: should we export the types?

Describe the proposed solution

• Add a types key to the exports in package.json

How important is this feature to you?

• Nice to have
• Would make my life a lot easier
• I cannot use swup without it

Describe the problem

• The global instance window.swup is not available immediately: #6
• Users might have to wait for the swup:enable event on the document before accessing it

Describe the proposed solution

• We should add a note about this and an example:

<script>
  console.log('swup not yet enabled', window.swup);
  document.addEventListener('swup:enable', () => {
    console.log('swup enabled', window.swup);
  });
</script>

Hello!
First of all thanks for this package. i was already using swup with astro for an year but this make everything cleaner and easy.

I just wanted to warn you that with the last version of yesterday (1.3.1) there is something broken with the SwupA11yPlugin (maybe some versions?).

I also tryed with a clean astro project and same error.

The error is: Uncaught (in promise) TypeError: Cannot create property 'announcements' on boolean 'true'.

Am i doing something wrong? Thanks!

Description of the issue
When assigning globalInstance: true in the configuration, window.swup returns undefined.

How to reproduce the issue

Just start an astro project with the CLI, install swup with the CLI, and assign globalInstance to true in the config.

Context and environment

Happens in Firefox and Chrome, haven't checked others.
@swup/astro version is 1.0.2.

// astro.config.mjs
import { defineConfig } from "astro/config";
import swup from "@swup/astro";

export default defineConfig({
  integrations: [
    swup({
      globalInstance: true,
    }),
  ],
});

// script anywhere in the app
console.log(window.swup) // returns undefined

Before creating this issue...

• Have you provided all helpful information available?
• Have you checked closed issues for similar/related problems?
• Have you considered creating a demo so we can help you better?

Describe the problem

When using a built in theme, we cannot pass a configuration object. this makes it impossible to change the direction of the overlay theme easely.

Describe the proposed solution

adding a themeConfig object that can be passed to the new SwupOverlayTheme() class, like so :

SwupOverlayTheme({
  direction: 'to-right'
});

How important is this feature to you?

• Nice to have
• Would make my life a lot easier
• I cannot use swup without it