swsnu / swpp2019-team10 Goto Github PK

currently AddReview.js is suffering from lack of coverage, and I found that most of uncovered line is from button handlers.

currently some button is using onClick handler and it seems to be working correctly when I actually run the frontend and test it.

however, even if I simulate clicking the button, jest doesn't count them as covered lines.

could anyone give some help on covering those handler functions?

According to our design and implmentation wiki, We are to use django-location-field and KaKao Map API.

But django-location-field seems to not supporting the KaKaoMap but Google Map. So if we are to use django-location-field , I think we have to change our location/search provider to Google Map.

I Think Google Map is better since our service is based on English except the name of menu and Our Sign in with SNS will support Google Login. What you guys think about it?

아이디는 중복 불가지만 닉네임은 중복 가능하게 되있는것 같습니다!

add review feature including Image upload, Google maps is in progress

Please comment
(1) What I have done in sprint 4
(2) What I will do in next sprint(just expectations are okay)

I've uploaded sprint 3 progress report and sprint 4 backlog. Note this if you need examples.
(https://github.com/swsnu/swpp2019-team10/wiki/Sprint-3-reports)

Please speicfy fixed api types and expected data form of RESTful API As soon as posible, to easily develop the frontend part.

problem / the importance of problem 1~3 (in my opinion)

1. Image load problem (3):

• [ We didn't implement properly the image handling part of frontend.]

2. Main view problem (3):

• [On location, It uses the outdated reviewList UI design.]
• [It doesn't filter the reviews by its distance from user.]

3. Location view problem (3)

• [On reviewDetail, the location of restaurant doesn't appear.]
• [On main/location, the marker for restaurants of reviews don't appear.]
• [On reviewDetail, marker doesn't appear in the middle of maps; sometimes the marker is out of the initial map range.]

4. ReviewDetail UI problem (2)

• [On reviewDetail, It uses the outdated reviewList tag design.]
• [Better Layout is required; smaller maps, smaller pictuers, bigger and readable title, author, etc information. Don't use textarea when the user cannot edit its content.]

5. Upload Problem (3):

• [Backend problem; It appears the backend cannot handle some specific input.
  For input 'Good Good I love sour pizza. I like lemon.', the backend returns error:
  /pytorch/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead. Good Good I love sour pizza. I like lemon. Internal Server Error: /api/review/ Traceback (most recent call last): File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/exception.py", line 35, in inner response = get_response(request) File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 128, in _get_response response = self.process_exception_by_middleware(e, request) File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python3.6/contextlib.py", line 52, in inner return func(*args, **kwds) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/views/review_views.py", line 98, in review_list tags = Tagging(request.user.profile, menu, rating).tagging(content) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 147, in tagging list_of_tags = self.tagging_for_recommend(text) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 185, in tagging_for_recommend if adj == tag: File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 211, in __eq__ return self.name.lemma == value.name.lemma and self.advmod.lemma == value.advmod.lemma AttributeError: 'NoneType' object has no attribute 'lemma']

• [When user select the place which is not a restaurant from the googleMap, execption below is thrown: Cannot read property 'includes' of undefined]

6. Recommendation view problem (3)

• [When we get reviews from recommendation, we can't see the reviewDetail of suggested restaurants.]
• [Recommendation by Location seems to broken; It doesn't show the list of restaurants.]
• [3. About taste, I cannot find the 'spicy' related keyword.]

7. Edit problem (3):

• [Edit don't works. It returns 400 Bad Request instead.]
  Fixed by @th-snu #108 but another problem occurs
• [After editing a review, new content is not updated until the page is refreshed.]
• [After closing the reviewDetail modal, the tag of reviewPreview in main component changes temporarily (until refresh) to default value.]

8. Main problem (3):

• [on friend's main page, the location, calendar, and category view shows the user's reviews, not the friend's reviews.]

Please leave a comment below about your python version
(The number when you type python --version in the console)

I need this for writing backend code..

구글 맵 연동이 안 되는 것 같습니다ㅜ

I searched various ways to handle image for REST api. I think we can consider 3 methods in this link.
https://stackoverflow.com/questions/33279153/rest-api-file-ie-images-processing-best-practices
I think many people liked second one. What do you think?

Will implement review_list and review_detail

https://docs.djangoproject.com/en/2.2/ref/contrib/postgres/fields/#querying-jsonfield
https://docs.djangoproject.com/en/2.2/ref/contrib/gis/model-api/#pointfield

I think those fields are more appropriate because they're built-in field in django.contrib. How about using them???

Let's fix the sprint 3 meeting time!!

https://docs.google.com/spreadsheets/d/127ZvDVj-YY3h0NMyTG9IcsT0uqozuDj_Axdos2eqhTw/edit?usp=sharing

저는 빈 시간 중에서는 목요일 오전이나 금요일 5시 이후만 가능합니다..

Wanted behavior will be in backend/README.md. I think we need to make backend as fast as possible for frontend.

recommendation이 필요한 api/restaurant 를 제외한 나머지 모델을 지금 만드는 것이 좋다고 생각합니다. 그래야 프론트엔드를 만드는데 도움이 될것 같습니다.

https://stackoverflow.com/questions/45984380/travis-ci-django-build-fails
I think it is problem of difference between sqlite and mysql. I think we need to update .travis.yml to resolve this error.

I thought that Google Calendar API is good for our services but I found out that

1. To implement Google Calendar API, "Sign in Google" feature has to be implemented in advance.
2. When we link the calendar and our services, our food review doesn't appear on google calendar. Instaed, schedule already saved on calendar appears. I think it is redundant information to our service (our service doesn't have to know what user's appointment/schedule is)

So I'll develop our 'Calendar' service with external Calendar component (react-calendar).

상단의 헤더에,
선택되어 있는 탭이 회색 처리가 되는 컨셉인 것 같은데,

탭 이동해도
바뀌질 않습니다~

1. Textblob : https://textblob.readthedocs.io/en/dev/

2. Spacy : https://spacy.io/

I'm thinking of a way to tagging before implementing recommendation. @ByungHeeCha has found 2 and I've found 1. I think of using 1 to analyze sentiment in sentence unit(https://textblob.readthedocs.io/en/dev/quickstart.html#tokenization) and using 2 to filter adjectives.(https://spacy.io/usage/linguistic-features#pos-tagging) In this way, we can find adjectives in comment and feelings on them.
We can just show adjectives or nouns corresponding that adjectives.

How about?

I think some modification / clarification are needed:

clarification
range of rating is 0 to 5, inclusive.
form of date is YYYY-MM-DD, leading zero inclusive.

modification
When getting review(s) I think the frontend doesn't have to know the id of author, restaurant, menu. Instead it should be "author": string, "restaurant": string, "menu": string.

api/review/

• POST : require json {"restaurant_name": string, "menu_name": string, "content": string, "rating": float}, return json {"id": id, "author": id, "restaurant": id, "menu": id, "content": string, "rating": float, "date": string}
• GET : return json list: each element: {"id": id, "author": id, "restaurant": id, "menu": id, "content": string, "image": url, "rating": float, "date": string}

api/review/:review_id/

• GET : return json response {"id": id, "author": id, "restaurant": id, "menu": id, "content": string, "image": url, "rating": float, "date": string}
• PUT : require json {"restaurant_name": string, "menu_name": string, "content": string, "rating": float}
  return {"id": id, "author": id, "restaurant": id, "menu": id, "content": string, "rating": float, "date": string}

api/review/:review_id/image/

• POST : require multipart/form-data "image":file, return {"id": id, "author": id, "restaurant": id, "menu": id, "image": url, "content": string, "rating": float, "date": string}

저희 팀이 만든 recommendation system의 성능을 테스트 해보기 위해서 데이터를 만들어서 테스트 해보기로 했습니다. 그러나 직접 우리가 만드는 방법은 시간도 오래걸리고 성능 테스트에 필요없는 필드 (예를 들면, Review의 content는 recommendation에는 필요가 없잖아요?)가 많을것 같습니다. 혹시 빠른시간에 많은 데이터를 DB에 집어넣을 수 있는 방법이 없을끼요?

like issue #56

Let's talk about our TODOs until tomorrow 6 P.M.
If clarification or discussion is requird, let's talk here together!

Further information will be based on backend/README.md

사진이 업로드가 안되서 그런 것인가요..?

I think we need some modification / additional api:

1. I think our servcies doesn't have to need user's age, phone_number, gender. It is good for remain optional fields. I think we can let user select they can submit addtional (not-essential) information on signing-up or edit it on their my page.

2. We need the api which returns user's id when the user's username (not nickname) is given. (-1 when not found). We have to develop duplicated ID check feature.

Let's find symptoms in our codes and discuss how to mitigate those symptoms!

Before developing views, We are going to use Semantic UI before our own CSS is added on later Sprint.

For better our understanding of view and (more importantly) the demo session, please use this CSS wrapper for frontend development.

For detailed explanation and how to use Semantic UI in our projects, please refer to Semantic UI Official Website.

I will fix those problems in hotfix_recommendation branch!