Use binding in an asyncResult computation expression about domainmodelingmadefunctional HOT 7 CLOSED

Looks like the implementation of the TryWith, TryFinally and other build upon those functions are flawed.

If you look at the implementation of TryFinally (code):

member this.TryFinally(body, compensation) =
    try this.ReturnFrom(body())
    finally compensation() 

Lets replace the call to ReturnFrom with it's body, and add a type on the body parameters

member this.TryFinally(body: unit -> AsyncResult<_>, compensation) =
    try body()
    finally compensation() 

Can you spot the problem?

The body function is returning an Async, it might not have completed yet. However the control flow in the TryFinally function already goes on, and as the execution of the body function already ended, the finally block is executed with the compensation function.

If you compare the internals of this Builder with the internals of the AsyncBuilder from the FSharp.Core you can see, that there the try-finally and try-with constructs are lifted into the Async world. In this version of the builder the constructs are left outside, that's why you have the difference in the behaviour.

from domainmodelingmadefunctional.

Think it makes sense, thanks.

from domainmodelingmadefunctional.

@mexx I changed the 2 methods like this:

member this.TryWith(body, handler) = async {
    try
        let! b = body()
        return this.ReturnFrom(b)
    with e ->
        return handler e }

member this.TryFinally(body, compensation) = async {
    try
        let! b = body()
        return this.ReturnFrom(b)
    finally
        compensation() }

The dispose works as expected now, but I'm not sure if it's really as simple as this, because the AsyncBuilder implementation of these is a lot more involved (perhaps because of doing optimizations?).

from domainmodelingmadefunctional.

@kerams I'm not certain that the calls to this.ReturnFrom are even necessary.

It's that simple, the AsyncBuilder implementation can't use any syntax sugar, like you do now with the async.

from domainmodelingmadefunctional.

Alright, thanks a lot!

from domainmodelingmadefunctional.

Just curious... Is this one fixed by #10?

from domainmodelingmadefunctional.

(Finally revisiting all these issues!)
I think this is fixed now. Closing

from domainmodelingmadefunctional.