Fails to build because module OrderTaking.PlaceOrder.Implementation is internal about domainmodelingmadefunctional HOT 3 CLOSED

Thanks for catching this and thanks for making a PR. I decided to handle this differently and just make the dummy implementations internal as well (which they should be anyway). So I will close the PR, but thanks again!

from domainmodelingmadefunctional.

@kentcb Another option to keep the actual implementation internal is to change module internal OrderTaking.PlaceOrder.Implementation to module OrderTaking.PlaceOrder.ImplementationTypes (for all the types that are declared in that file) and then in section 2 where the actual implementation of the various functions takes place, create an internal module called module internal Implementation (you'll have to define it like so module internal Implementation = and then indent everything underneath that).

Once you've done that, you just need to change the OrderTaking.PlaceOrder.Api module to qualify the types with ImplementationTypes (e.g. ImplementationTypes.CheckedAddress). You'll also have to change the placeOrderApi workflow function (at the bottom of the file) to be like so:

let placeOrderApi : PlaceOrderApi =
...
    let workflow = 
                ImplementationTypes.Implementation.placeOrder 

This exposes the types as public, but keeps the actual functions using the types as internal.

To answer your question about the compiler improvement, yes, it was a change (in 4.1 I think) to turn that into a compiler error. You can also trigger a similar compiler warning (not error) if you were to leave the code as is and add the following line as a type alias in PlaceOrder.Api:

type CheckAddressExists = Implementation.CheckAddressExists

from domainmodelingmadefunctional.

I've created a PR for this (I guess I did it wrong because it opened a new issue, oops). The PR is issue #17

from domainmodelingmadefunctional.