sweetchuck / drupal-marvin_product Goto Github PK

Do not enable/disable field_ui module in drush.yml
marvin.environments.local.modules.field_ui

Use all the shiny feature from CircleCI 2.x

@todo

• composer.lock#/content-hash
• custom codes

In /sites/all/translations directory all the *.po files which are belong to custom modules (very likely only app-VERSION-LANGCODE.po) have to be renamed according to the new version number.

$config['locale.settings']['translation']['path']

Same notification should be displayed on marvin:git-hook:post-merge event as we have on marvin:git-hook:post-checkout.

• composer.json or composer.lock changed
• package.json or yarn.lock changed

The marvin:toggle-modules command should throw an error if the given marvin.environment is not exists as a key in the marvin.environments array.

The fundamental components should be implemented in drupal/marvin

• https://github.com/phpstan/phpstan
• https://github.com/mglaman/phpstan-drupal
• https://packagist.org/packages/phpstan/phpstan-deprecation-rules

Currently the marvin:build commands rely on the nvm script.

Make it optional.

The marvin:onboarding command should do nothing on its own.
It should do something like this: $this->delegate('onboarding');

Add PHP 8.1 support

https://github.com/Sweetchuck/drupal-marvin_product/blob/8.x-1.x/Commands/marvin_product/ArtifactBuildProductCommandsBase.php#L260

After a composer require command list the newly available Drupal modules and themes and profiles, with the corresponding Drush command. For example drush pm:enable foo.

Messages which explain what will happen during the execution (which modules will be enabled or disabled) should be logged as info instead of a debug message.

https://github.com/Sweetchuck/robo-cdd

• *.libraries.yml / dependencies
• *.info.yml / dependencies
• migration dependencies
• etc

\Drush\Commands\marvin_product\ArtifactBuildProductCommandsBase::isApplicable

• project
• product
• drupal-project
• drupal-product

• @command marvin:env-config:settings-php
• \Drupal\marvin_product\EnvConfig\EnvConfigHandler::normalize

• behat.local.yml
• phpunit.xml
• drush/drush.local.yml
• docroot/sites/*/settings.local.php
• gulp.config.json

Task is to create symlinks based on the given environment.
The command should use ::delegate().

This will affects the marvin:onboarding command as well.

The marvin:onboarding command should fail when the project still on template phase

With -vvv I can get the error message, but the exit code is 0

Onboarding is skipped, because this project is still in template phase.

(one can run into this problem only if the project wasn't initialized properly)

In NpmCommands::onEventMarvinBuild the yarn install maybe uses a wrong version of node.

Add support for --parents in marvin:env-conf:settings-php command

I thinkt he marvin:onboarding command wold be able to generate a phpunit.xml file with the correct values.

• SIMPLETEST_BASE_URL

\Drush\Commands\marvin_product\MigrateCommands::getTaskMigrateImportDoIt()

Do not deploy those Git hook scripts which have no subscriber.

Package version diff between two composer.lock

When the composer.json contains a reference to a patch file like this:

{
    "extra": {
        "patches": {
            "Foo": "./patches/bar.patch"
        }
    }
}

Then the "composer install" command failing during the artifact generation (marvin:artifact:build:vanilla)

Proposed solution

Add a new task before the "composer install --no-dev" task, which copies the "patches" directory from the project root to the build directory.
And add another new task after the "composer install --no-dev" task, which removes the previously copied "patches" directory, because it is not needed to be in the artifact.

Sometimes a file like this also part of the artifact ./sites/all/translations/devel-4.1.1-XX.po, but it should not if the devel module is not part of the artifact.

Helper command to restore the site from backup.
By default the backup directory is in the outer sites directory.
./sites/default/backup
drush core:rsync
drush sql:dump
drush sql:cli < foo.mysql

Wrong drush_invoke_process() return value validation in @command marvin:migrate

\Drush\Commands\marvin_product\MigrateCommands::getTaskMigrateImportDoIt

$response = drush_invoke_process($cmdSiteAlias, $cmdName, $cmdArgs, $cmdOptions);
if ($response === FALSE || !empty($response['error_status'])) {
  $this->getLogger()->error('migrate:import failed.');

  return 1;
}

After the marvin:onboarding command the trusted_host_patterns is not updated in docroot/sites/default/settings.local.php

config/sync/core.extensions.yml should not contain any module which comes from composer.json#require-dev

Note: Config managed by config_split can be a tricky one.