Giter Club home page Giter Club logo

cptools2's People

Contributors

swarchal avatar

Watchers

 avatar

cptools2's Issues

yoko parsing, issues when plate has been imaged twice

If a plate has been imaged twice there's two plate sub-directories within the plate directory which causes the LoadData dataframe to contain twice the number of expected rows.

We need a better way of checking for plate duplications, and for the LoadData module to handle this.

incorportate scissorhands code

Due to some unique IT decisions, it's probably easy to include the scissorhands in this repo rather than have it as a dependency.

LoadData fails if some channels have unequal number of z-stacks

The CV8000 has the option of imaging some channels with multiple z-stacks and others without.
It's not likely this is going to happen with a screen but it's causing problems in testing, where the LoadData csv file has rows with empty channels for those with no image in that z-location.

Options
- Only image with equal z-stacks per channel, check for this and raise an informative error if not true
- Duplicate image paths for the missing channels for the z-locations we have

Store intermediate state as JSON

config.yml -> JSON which contains all the PlateStore, and LoadData?

Might require re-writing a lot of stuff to only operate on dictionaries, the PlateStore is already a dictionary, not sure how best to serialize the dataframes.

Clarify expected behaviour with identically named plates in separate experiments in the same config file

If we add two experiments that share plate names, I'm not currently sure what happens.

There are at least 2 issues that will happen with this:

  1. LoadData csv files with identical names will overwrite each other, or they are possibly overwritten as dictionary keys in the plateStore implementation.
  2. Trying to remove plates without specifying which experiment is ambiguous.

We need to define the behaviour, or at least raise a warning/error if this happens.

# experiment with plates named plate_A01, plate_A02... etc
experiment: /path/to/experiment_A

add plate:
    - experiment: /path/to/experiment_B
    - plates:
        - plate_A01
        - plate_A02
        - plate_A03

remove plate:
    - plates:
        - plate_A01

Options:

  1. Detect if this happens and error, experiments should not share a config file if they have identically named plates.
  2. Name LoadData csv files including the experiment name so they are not overwritten. In addition, remove plate in config needs to specify an experiment in addition to plate names.

Remove eddie-specific checks

There's some instances where it's checking for environment variables to maek sure it's on the right node which won't apply in this case.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.