sverweij / mscgen_js Goto Github PK

Looking into use of foreignObject/ xhtml solution

=> include .png saving via canvas?

• store the colors in a hash map
• either update arcs in the parse tree with the stored colors, or look up the colors during rendering
• arclinecolor
• arctextcolor
• arctextbgcolor

Replaced the ribbon with an icon because it clashed with other clickable areas in the top right. Accidentally also solves this issue.

Input

3=>>".";

Actions taken
Convert to mscgen:

Expected result

msc {
  3,
  "."
}

Found

msc {
  3,
  .
}

Which is no valid mscgen program. The problem works two ways; mscgen with "." in it translates to . entities in smpl.

maybe first complete #3? If foreignObject/ HTML is the chosen route there ID and IDURL will be fairly simple to implement.

In microsoft internet explorer, at least up until and including version 8, mscgen_js is only able to do do syntax checking. It will, however, not render a sequence chart.

From experience I know that supporting internet explorer and, in particular, more early versions can take up a lot of time. As my time is limited, and the target users of msgen_js are likely to have other browsers at their disposal, I decided to make no attempt at supporting IE.

I read that from version 9 and up internet explorer supports svg, so msgen_js could work there. I have not verified whether this actually is the case.

Probably because I'm loading/ including the plugin incorrectly

a => b;: no problem
a => b: some text;: arc & entities disappear.
Opera only (tested in 12.16)

probably the problem is in this for the thing that renders the background of the text:

<rect width="-Infinity" height="-Infinity" x="3.4028234663852886e+38" y="3.4028234663852886e+38" class="textbg"/>

Which suggests getBBox isn't working well in Opera.

B.t.w. the .png and .jpeg rendered through canvg look fine.
Update 20131111: canvg rendering is also kaput

This input

width=600;
a => b;

generates this output

'nuff said. Small sizes look even worse:

Without the width statement it looks like this, which is a lot better:

Currently emphasis arcs are renedered with a red line and closed arrows. mscgen standard implementation is a double line (<===========>)

• make special case for ":" arcs and save in boolean
• make createDoubleLine function in utensils
• if special case true createDoubleLine i.o. createLine

a,b;

a :> b: rfi;
a <:> b: also rfi;
|||: shudder, 
a :> a,
b <:> b;

'nuf said

input

a,b,c,d;
a=>c: do something ;
*<<=c : this does work ;
c=>>*; # this works too
c=>>* : this doesn't ;
b>>a: it's working ;

expected
Diagram gets rendered.

found
Error message: 'undefined' is not an object.

analysis
The broadcast arc labeled _this doesn't _ generates this message.

current situation
"Cannot convert pX2 to object." When referencing a non-existing entity.

• Should be something like "Entity 'yadda' is not defined"

"Cannot convert pEntoties to object." When no entity defined

• Should be something like "No entities defined"

Relation with issue #13?

steps taken

msc {
1,2[arclinecolor="blue"],3;
1=>>2;
2:>3 [label="colored blue"];
2=>>* [label="colored blue", arcskip="1"];
|||;
*<<=2 [label="colored blue", arcskip="1", id="bug"];
|||;
2<<=3 [label="colored black", id="bug"];
}

expected
lines labeled as "colored blue" are colored blue, those "colored black" colored black.

found
the arcs labeled with id="bug" have a different color

Explicitly clean canvas?

a, b;
a NOTE a,
b aBOx b;

both render as arrowles arcs

a NoTE a;
a RBOX b;

same here for ms genny ...

Arrowheads stay black right now. Probably because the programatic style override is set on the line only.
Will setting it on group level help?
Does a css property exist for formatting marker-ends && starts?

Relation with issue #14?

maybe first complete #3? If foreignObject/ HTML is the chosen route there ID and IDURL will be fairly simple to implement.

Steps taken

msc{
a, b;
b note a;
b abox a;
}

expected
A note and an abox are rendered.

found
Two weird shapes are rendered.

a -> b renders the arrow on the bottom (ok)
b -> a renders the arrow on top (nok)
a <-> b renders both arrows bottom (ok)
b <-> a renders both arrows on top (nok)
a -> a renders the arrow on top (nok)
a <-> a renders the first arrow bottom (ok) the second on top (nok)

Target: when text is longer than horizontal the space it fits in, mscgen_js automatically wraps it.

• algorithm
• only wrap non box'ish arcs when the wordwraparcs option = true

Current: the hight of an arc row is fixed.
Target: the hight of an arc row is just a tad bigger than the largest hight of any of its arcs.

Steps taken
use this as input:

  msc {
   render , error_output, textcopylightbox;
  }

expected
Three entities are rendered with render, error_output and textcopylightbox as labels

found
The entities were rendered, but labels and entity boxes are not shown.
The textcopylightbox entity gets shown when you click "show svg", but the svg isn't shown in these cases ...

analysis
these specific entity names are equal to html elements elsewhere on the page that are usually not displayed because of a display:none css styling rule. Ideally the css rules for the surrounding html should be written in such a way that the svg tree is never affected.

• split source and deployable code
• split lib from src
• peg node modules
• peg web modules
• funky foo to reuse parsetree2x node modules in web version
• r.js for js
• r.js for css