sveinbjornt / iceaddr Goto Github PK

Are you planning to make new releases with periodical updates to staðfangaskrá? It’s updated every week on the skra.is FTP server. Or are users encouraged to keep their own sqlite db up to date?

It seems like at least "Höfn í Hornafirði" and "Sauðárkrókur" are missing from the place name list.

Out of the box behaviour (v. 0.5.5, PyPI):

>>> from iceaddr import placename_lookup
>>> placename_lookup('Meðalfellsvatn')
[{'id': 59021, 
'nafn': 'Meðalfellsvatn', 
'flokkur': 'Vatnaörnefni Mið', 
'lat_wgs84': 225798.99670902034, 
'long_wgs84': 2574241.490482475 }]

Note the ISN93 lat_wgs84 and long_wgs84 values.

After cloning and running build_db.py and add_placename_data.py, with latest IS50V data and running the module locally:

>>> from iceaddr import placename_lookup
>>> placename_lookup('Meðalfellsvatn')
[{'id': 58989, 
'nafn': 'Meðalfellsvatn', 
'flokkur': 'Vatnaörnefni Mið', 
'lat_wgs84': 64.31120378256016, 
'long_wgs84': -21.599793276028475}]

This matches the intended behaviour.

Looking at the original iceaddr.db file, the only placenames with WGS84 coordinates are the ones added manually from placename_additions.txt. The rest (160.000+) entries have ISN93 coordinates (I guess? These aren't WGS84 coordinates at least).

@sveinbjornt You mentioned in #4 (comment)_ that you wouldn't be doing regular updates, but this looks like an error from the last commit (f2eb867).

The new postcode 102 is missing from postcodes

Other versions install without issue, however when installing 0.4.0 via pip on Windows 10 gives a UnicodeDecodeError:
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8d in position 5242: character maps to