sv443-network / svcorelib Goto Github PK

I'm such a fucking idiot

This async function would go through an array of directory paths, creating any missing directories

• .forEach loop isn't entered since this._blacklistPattern is an empty array.
• Additionally, the same file hash is probably added onto the promises array multiple times. A return after line 164 would probably fix this.

At src/classes/FolderDaemon.js:157

Like randomItem() but mutates the array to remove that item
Alternatively add this as a param to randomItem()

Step 1:
File content foo
*onChanged is called*

Step 2:
File content bar
*onChanged is called*

Step 3:
File content foo
*onChanged is NOT called*

Basically this: https://github.com/Sv443/JokeAPI/blob/version/2.4.0/src/exists.js

fs.exists() was deprecated because its bevahior differed from that of other async Node.js functions. This feature would re-implement fs.exists() by only using the recommended fs.access() and returning the same value as fs.exists() did, a boolean. Additionally, this function uses path.resolve() as an additional measure.

This is the correct way:

function softShutdown(funct: () => void, code?: number): void;

To wrap around the whole format parameters & reserialize output thing

Since it's different on Windows and *nix this would be a good addition.

This base class should handle custom implementations such as the date property

Something like

function reserialize(obj: T extends JSONCompatible): T;

Returns a tuple of random item and its index

For example:

readableMs(123056); // 2min, 3s and 56ms

Possible fix:

Use inspector.url(), also check for the NODE_ENV env variable.

Node version: 16.6.1
SCL version: 1.14.1

Something like

const items = [ "foo", "bar" ];
const weights = [ 1, 2 ];

const result = scl.weightedRandom(items, weights);

would return a random entry of the items array, but the RNG should be modified, so that "bar" is 200% likely to occur, while "foo" is only at 100%, so "bar" is twice as likely to be returned as "foo".

Optional feature:

Add an overload to this new function that needs to be passed an iterator function to resolve each array items' weights; this is kinda how the Array.map() and Array.reduce() methods work:

const items = [ "foo", "bar", "baz" ];

function iterator(current, last, all)
{
	// return the char code of the first letter of the string
	// letters further down the alphabet have a higher weight (a = 1, z = 26)
	const weight = (current.charCodeAt(0) - 96);

	// Default to weight 1 if somehow the calculations above can produce NaN
	if(isNaN(weight))
		return 1;

	return weight;
}

const result = scl.weightedRandom(items, iterator);

The iterator function gets called on each item and it should return a number that's not NaN (check with isNaN()). Everything that is returned will be accumulated into the weights array of the previous example and based on this a random item is selected and returned.

see docs:

Like can stuff just work please? I'm tired of fixing everything

Argument checkArg: string is missing:

1. Find a bundler that does CJS, ESM and TS
2. Do the migration thingy (yuck)
3. Cry
4. PAin
5. suffering
6. done :)

I just want to monitor a single file in https://github.com/Sv443/JokeAPI
Instead of the optional filesBlacklist, recursive and updateInterval parameters, it could be an object with whitelist, blacklist, recursive and updateInterval props

see https://2ality.com/2021/06/error-cause.html#consequence-for-your-own-code

Solution: add check for null and undefined in the second ("objects") row: (input !== null && input !== undefined) && [...]

Currently mysql is declared as a dependency, meaning it must be installed (even if it is not needed), adding quite a lot of sub-dependency clutter.
Solution is to declare it as a peer dependency and doing some Node magic to throw an error if a peer function is used without its dependency.

Using the below example code demonstrates how SCL makes the prompts library capture keyboard input twice, after a SelectionMenu was opened at some point

const prompt = require("prompts"); // https://www.npmjs.com/package/prompts
const { SelectionMenu } = require("svcorelib");

const sm = new SelectionMenu("Example");

sm.setOptions([ "Foo", "Bar" ]);

sm.onSubmit(async () => {
    const { res } = await prompt({
        type: "text",
        name: "res",
        message: "Enter something:",
    });

    console.log(res);
});

sm.open();

I believe not even using sm.close() helped.

Example:
String = Foo %1 Bar %2 Baz %3
Values = Apple, Banana, Orange
Result = Foo Apple Bar Banana Baz Orange