susurrus-llc / langua Goto Github PK

For example: https://github.com/nai888/langua/blob/master/src/styles/functions.js

const isCoolColor = (color) => {
  return color.hue < 300 && color.hue > 120
}

const isHighKeyValue = (color) => {
  return color.hue > 30 && color.hue < 140
}

const isHighestKeyValue = (color) => {
  return color.hue > 50 && color.hue < 105
}

All instances of color.hue should be color.hue().

The Open button currently unhides the file input field, which then needs to be clicked in order to open a file. Instead, the open button itself should open the file directly to reduce the number of clicks required.

Add a changelog, e.g. like https://keepachangelog.com

Langua Version

v0.2.0

Expected Behavior

The tooltip that appears when hovering over a bar should disappear when the mouse leaves that bar without hovering over a new bar.

Actual Behavior

The tooltip stays in place until the mouse leaves the entire bar graph area, rather than disappearing as soon as the mouse leaves that particular bar.

Steps to Reproduce

Hover over a bar in the Frequen bar graph, then move the mouse off the bar into empty space in the graph.

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating @fortawesome/fontawesome-free in /yarn.lock:
Couldn't find package "xregexp@^4.3.0" required by "[email protected]" on the "npm" registry.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Review the create-react-app README's recommendations for creating a fully functioning progressive web app, and the offline behavior in particular.

Check out this page for help with notifying about available updates.

This code will be handled at around line 63 of registerServiceWorker.js.

Check out react-toastify as a possible way to handle the notifications themselves.

Langua Version

0.1.3

Desired Behavior

Add a notice for when the browser has cached the app and it can be accessed offline. Ideally, also notify users they can add Langua to the home screen of their mobile or tablet.

Add a notice when the server's version of Langua is different from the cached version, indicating that the user should refresh the page to load the newer version.

Home styles should refactor the panel:hover rule so it's not panel:link:hover.

Change

const styles = {
  grid: {
    display: 'flex',
    justifyContent: 'space-between',
    alignItems: 'baseline',
    flexWrap: 'wrap'
  },
  panel: {
    '&:link, &:visited, &:hover, &:active': {
      color: v.black.string(),
      width: '49%',
      marginBottom: `${v.lnht}rem`,
      padding: `${v.ms0}rem`,
      boxSizing: 'border-box',
      '&:hover': {
        outline: {
          width: '1px',
          style: 'solid',
          color: v.blu.darken(0.15).alpha(0.3).string()
        }
      }
    }
  },
  toolDescription: {
    margin: 0
  }
}

to

const styles = {
  grid: {
    display: 'flex',
    justifyContent: 'space-between',
    alignItems: 'baseline',
    flexWrap: 'wrap'
  },
  panel: {
    '&:link, &:visited, &:hover, &:active': {
      color: v.black.string(),
      width: '49%',
      marginBottom: `${v.lnht}rem`,
      padding: `${v.ms0}rem`,
      boxSizing: 'border-box'
    },
    '&:hover': {
      outline: {
        width: '1px',
        style: 'solid',
        color: v.blu.darken(0.15).alpha(0.3).string()
      }
    }
  },
  toolDescription: {
    margin: 0
  }
}

Langua Version

0.1.3

Expected Behavior

Show the number of words, filtered words, and possible words with commas every 3 digits.

Actual Behavior

Shows a string of digits with no delineation.

Steps to Fix

Implement number.toLocaleString() when printing the numbers.

Langua Version

v0.3.1

Request

Related to #140.

Add arial-label to all inputs that don't already have a label in order to improve accessibility throughout the site.

Langua Version

0.1.4

Expected Behavior

Buttons should behave like button and links should behave like links. There shouldn't be a link that looks like a button.

Actual Behavior

The Help and Back buttons are currently links that look like buttons. Fix this.

Steps to Solve

Create a ButtonLink, a button that reroutes to a new URL by wrapping it in withrouter.

Also add cursor: pointer CSS to all buttons for visual affirmation of interactivity.

Is your feature request related to a problem? Please describe.
Gen currently allows options but no other features. Adding units (options surrounded by [ ] brackets) will improve succinctness of input.

Describe the solution you'd like
Add the ability to use [ ] brackets to demarcate single units. For example, the code s[tu/top/kan] will produce the output stu stop skan.

Additional context
You can find the instructions for using this feature within Awkwords in its help file.

Related issues
#63

[![Dependabot Status](https://api.dependabot.com/badges/status?host=github&repo=nai888/langua)](https://dependabot.com)

Current Code

const isCoolColor = (color) => {
  return color.hue < 300 && color.hue > 120
}

const isHighKeyValue = (color) => {
  return color.hue > 30 && color.hue < 140
}

const isHighestKeyValue = (color) => {
  return color.hue > 50 && color.hue < 105
}

Original Code

tallys/color-theory has the following:

@function is-cool-color($color) {
  @return hue($color) < 310 and hue($color) > 140;
}

@function is-high-key-value($color) {
  @return hue($color) > 20 and hue($color) < 190;
}

@function is-highest-key-value($color) {
  @return hue($color) > 30 and hue($color) <90;
}

Also Look Into Adding More Functions

tallys/color-theory has the following not currently included:

@function pick-contrast-of($color) {
  @if is-high-key-value($color){
    @if lightness($color) < 30% {
      @return lighten(complement($color), 86);
    }
    @else if lightness($color) > 70% {
      @return darken(complement($color), 68);
    }
    @else {
      @return darken(complement($color), 53);
    }
} @else {
  @if lightness($color) < 30% {
      @return lighten(complement($color), 86);
    }
    @else if lightness($color) > 70% {
      @return darken(complement($color), 68);
    }
    @else {
      @return lighten(complement($color), 53);
    }
  }
}

Is your feature request related to a problem? Please describe.
Gen currently allows options but no other features. Adding optional units (options surrounded by ( ) parentheses) will improve succinctness of input.

Describe the solution you'd like
Add the ability to use ( ) parentheses to demarcate single optional units. For example, the code s(tu/top/kan) will produce the output s stu stop skan.

Additional context
You can find the instructions for using this feature within Awkwords in its help file.

Related issues
#62

Is your feature request related to a problem? Please describe.
There is currently no way to control the frequency of certain results. This should be added via weights.

Describe the solution you'd like
Add the ability to use * asterisks to weight certain options more than others. For example, the code CV*2/CVC will produce output where the pattern CV is twice as likely to appear as CVC is.

Additional context
You can find the instructions for using this feature within Awkwords in its help file.

Is your feature request related to a problem? Please describe.
There is currently no way to filter Gen's results. This should be added via filtering.

Describe the solution you'd like
Add the ability to use ^ carets to filter certain results. For example, if V is a subpattern a/i/u, the pattern [VV]^aa^ii^uu would produce the results ai au ia iu ua ui but never any of aa ii uu.

Additional context
You can find the instructions for using this feature within Awkwords in its help file.

Expected

styles: {
  '@global': {
    h6: {
      color: v.blu.string()
    }
  }
}

Actual

styles: {
  '@global': {
    h6: {
      color: v.blu
    }
  }
}

https://github.com/nai888/langua/blob/master/src/styles/variables.js

Instead of lightening and darkening bluNtl, make it grayscale first using color.grayscale().

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error while updating /yarn.lock:
Couldn't find any versions for "scheduler" that matches "^16.6.2"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Langua Version

0.1.3

Expected Behavior

Load each page's styles accurately, even if accessing a subpage directly.

Actual Behavior

When loading a subpage directly, the CSSinJS classes are assigned incorrectly, which causes elements to have the wrong appearance.

Steps to Reproduce

Load a subpage directly (e.g. go straight to https://nai888.github.io/langua/gen without loading the homepage first).

Note: since react-snap doesn't come into play until the build process, the issue only happens on the built static site, not on the development server.

Observations

This is an issue with react-snap generating a static HTML file with predefined CSS classes and then CSSinJS dynamically assigning the CSS classes to elements on the page. This is why loading the home page first works, because the elements are rendered in the "correct order" for the classes to be dynamically assigned to elements in the correct order.

Langua Version

v0.2.0 through current

Expected Behavior

When hovering over a bar in the bar graph in the results selection of Frequen, the tooltip with additional information about that particular bar should appear near the cursor.

Actual Behavior

The tooltip always appears in the upper left corner of the bar graph instead of appearing near the cursor.

Steps to Reproduce

Hover over a bar in the Frequen bar graph.

Langua Version

v0.4.2 through current

Expected Behavior

All phonemes in the Frequen consonants and vowels boxes should be converted to lowercase and deduped before analysis if distinguish upper and lower case = false.

Actual Behavior

When a phoneme with an allophone is capital and/or if its allophone is capital, the system crashes and the console prints the following error twice:

TypeError: Cannot read property 'count' of undefined
    at e.value (FrequenService.js:249)
    at t.<anonymous> (index.js:66)
    at oa (react-dom.production.min.js:4271)
    at ra (react-dom.production.min.js:4257)
    at Ba (react-dom.production.min.js:4983)
    at qa (react-dom.production.min.js:5123)
    at react-dom.production.min.js:5975
    at Object.t.unstable_runWithPriority (scheduler.production.min.js:274)
    at ju (react-dom.production.min.js:5974)
    at Cu (react-dom.production.min.js:5958)

This is likely caused by converting all phonemes to lowercase but failing to dedupe the allophones. Check that first.

Steps to Reproduce

Change a phoneme with an allophone and/or an allophone to a capital version of itself, make sure distinguish upper and lower case is unchecked, then click analyze.

I'd like to get code coverage up to at least 60%, preferably higher.

Is it possible to add word-initial and word-final patterns to LanguaGen?

For example, CV$(C)V(C)$VC would mean that a CV pattern is put in the initial syllables, then (C)V(C) as all the medial syllables, then VC as the final syllable.

I couldn't find any word generators that had this feature.

Thanks

Update the styling in the Header and Home styles to dim or gray-out the tools that aren't ready yet.

Let the controls wrap and increase spacing above and below .controlPiece so that the spacing is better when it does wrap.

control: {
  flexWrap: 'wrap'
},
controlLeft: {
  flexWrap: 'wrap'
},
controlPiece: {
  margin: `${v.lnht}rem`
}

Is your feature request related to a problem? Please describe.
There is currently no way to use control characters as characters you want in your results. This should be added via escaping.

Describe the solution you'd like
Add the ability to use " " quotes to escape control characters. For example, the pattern s[tu/ka] would produce stu ska, but the pattern s"[tu/ka]" would produce the output s[tu/ka].

Additional context
You can find the instructions for using this feature within Awkwords in its help file.