superronancraft / bettereconomy Goto Github PK

for example, I want to connect it to my table and show it my column with money, for example, to link it to the site, ie with coins on the site

Balance not properly formatted value when displayed as a string.
If a player has several millions worth. The value will be written as 1.343433E7 for example.
This needs to output the correct value and not the exponential value as a string! :)

1. Database.java does not close its PreparedStatements and ResultSets. This leads to a resource leak over time. To fix this, the resources should be closed when done, preferably with a try-with-resources block:

try (PreparedStatement stmt = /* ... */; ResultSet rs = stmt.executeQuery()) {
  // do SQL stuff here
} catch (SQLException ex) {
  // handle exception
}
// PreparedStatement and ResultSet are automatically closed

2. MySQLConnection does not use a proper connection pool, and rather gets or re-initialises a single Connection every time it is acquired.

While this may work most of the time, it has problems. Connection is not always thread safe, and if it is, sharing it across threads is pointless as one will starve the other. Keeping one open for long periods of time will lead to network timeouts.

The best way to solve this is by using connection pooling library, which will handle timeouts appropriately and re-create Connections as needed in a better manner. HikariCP is my go-to and is widely used.

Sometimes, rather when the server is restarted (I think) the balance for several users are set to -1.
This does not happen when using the database.yml backend.

How to get the code for HikariDataSource, HikariConfig and so on?