supercam19 / enchantmentdetails Goto Github PK

This seems to be the next logical step in improving this datapack, adding the ability to detect and update the descriptions of enchanted books inside of chests. Since only in very rare scenarios will an enchanted book end up in a player placed chest without going through a players inventory, it might be best to try to make this process only happen upon the generation of a naturally spawning chest. If I am correct (which I probably am not) enchanted books will only naturally spawn in chest blocks, and in no other storage block, which means I shouldn't have to add detection to barrels, for example.

Right now, the banner image for the datapack is low effort and unapealing. The datapack also lacks a pack.png, which is less of an issue since it is rarely seen, but it would make a nice addition to make the datapack feel more complete.

• Create new banner image
• Create pack.png

I think it would be convenient for people who want to change something in the datapack to have a spreadsheet which the python scripts will read from to generate description files. This way the spreadsheet (and thus the descriptions) can be modified very easily, and by running a python script generate the files for the enchantment descriptions.

This would also make translation very easy to make.

A checklist of small additions, changes and fixes that I will be completing for the 1.2.0 update.

Additions

• Console logging for python scripts, such as when there's an error or to indicate that the files were successfully generated

Changes

• Change several enchantment descriptions to better represent what the enchantment does
• Add a generate_pack.py script that generates all files for the datapack at once.
• Empty output folder when running one of the generator scripts, so you don't have .mcfunction and .json files in the same folder at once
• Add json formatting (indentations and newlines) to the generated advancement files
• README.md updates:
  • Add install instructions
  • Test compatible minecraft versions, and create list

Fixes

• Fix several enchantment descriptions with spelling mistakes
• Fix sweeping edge not getting a description

More may be added before the 1.2.0 update is released.